Social: Clean up media auto-conversion backend logic

projects/packages/publicize/.phan/baseline.php

@@ -30,7 +30,6 @@
 
     // Currently, file_suppressions and directory_suppressions are the only supported suppressions
     'file_suppressions' => [
-        'src/auto-conversion-settings/class-rest-settings-controller.php' => ['PhanPluginMixedKeyNoKey'],
         'src/class-connections-post-field.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],
         'src/class-keyring-helper.php' => ['PhanTypeMismatchArgumentProbablyReal', 'PhanTypeMismatchDefault'],
         'src/class-publicize-base.php' => ['PhanImpossibleCondition', 'PhanPluginDuplicateConditionalNullCoalescing', 'PhanPluginSimplifyExpressionBool', 'PhanSuspiciousMagicConstant', 'PhanTypeMismatchArgument', 'PhanTypeMismatchArgumentNullable', 'PhanTypeMismatchArgumentNullableInternal', 'PhanTypeMismatchDimFetch', 'PhanTypeMismatchReturn'],
@@ -42,7 +41,6 @@
         'src/social-image-generator/class-rest-settings-controller.php' => ['PhanPluginMixedKeyNoKey'],
         'src/social-image-generator/class-settings.php' => ['PhanPluginDuplicateConditionalNullCoalescing'],
         'src/social-image-generator/class-setup.php' => ['PhanTypeMismatchArgumentNullable'],
-        'tests/php/jetpack-social-settings/test-auto-conversion.php' => ['PhanDeprecatedFunction', 'PhanPluginDuplicateConditionalNullCoalescing'],
         'tests/php/jetpack-social-settings/test-jetpack-social-settings.php' => ['PhanDeprecatedFunction'],
         'tests/php/test-connections-post-field.php' => ['PhanDeprecatedFunction', 'PhanTypeMismatchArgument'],
         'tests/php/test-publicize-og-optimization.php' => ['PhanDeprecatedFunction'],

projects/packages/publicize/changelog/update-social-clean-up-media-auto-conversion-backend-logic

@@ -0,0 +1,4 @@
+Significance: minor
+Type: removed
+
+Social: Cleaned up media auto-conversion backend logic

projects/packages/publicize/src/class-publicize-base.php

@@ -2028,6 +2028,8 @@ public function has_social_image_generator_feature() {
 	/**
 	 * Check if the auto-conversion feature is one of the active features.
 	 *
+	 * TODO: Remove this after certain releases of Jetpack v15.
+	 *
 	 * @param string $type Whether image or video.
 	 *
 	 * @return bool

projects/packages/publicize/src/class-publicize-setup.php

@@ -46,10 +46,6 @@ public static function on_jetpack_feature_publicize_enabled() {
 		add_action( 'rest_api_init', array( static::class, 'register_core_options' ) );
 		add_action( 'admin_init', array( static::class, 'register_core_options' ) );
 
-		// Flagged to be removed after deprecation.
-		// @deprecated 0.38.3
-		add_action( 'rest_api_init', array( new Auto_Conversion\REST_Settings_Controller(), 'register_routes' ) );
-
 		( new Social_Image_Generator\Setup() )->init();
 	}
 

projects/packages/publicize/src/class-rest-controller.php

@@ -339,7 +339,7 @@ public function get_dismiss_notice_endpoint_schema() {
 				'notice'            => array(
 					'description' => __( 'Name of the notice to dismiss', 'jetpack-publicize-pkg' ),
 					'type'        => 'string',
-					'enum'        => array( 'instagram', 'advanced-upgrade-nudge-admin', 'advanced-upgrade-nudge-editor', 'auto-conversion-editor-notice' ),
+					'enum'        => array( 'instagram', 'advanced-upgrade-nudge-admin', 'advanced-upgrade-nudge-editor' ),
 					'required'    => true,
 				),
 				'reappearance_time' => array(

projects/packages/publicize/src/jetpack-social-settings/class-dismissed-notices.php

@@ -28,7 +28,6 @@ public function register() {
 					'schema' => array(
 						'type'       => 'object',
 						'properties' => array(
-							'auto-conversion-editor-notice' => array( 'type' => 'number' ),
 							'advanced-upgrade-nudge-admin' => array( 'type' => 'number' ),
 							'advanced-upgrade-nudge-editor' => array( 'type' => 'number' ),
 						),