-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Logo Generator: fix upgrade links #38598
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on Jetpack and Simple
Fixes #38596.
Proposed changes:
useCheckout
hook to work for any site typeai-client
package, updating the imports over the code and then reusing it here, what is a big change; I added a draft task for it, so we can tackle it when we see this tool gaining tractionOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
There are 4 scenarios to test here:
We need to simulate the scenarios and the best way to do it is using the backend filters that change the active tier of a site; the snippets for the test scenarios are provided at the end of the testing instructions
For any scenario:
So it is important to test it on a Jetpack site and a Simple site.
Expected behavior on the free plan:
Expected behavior on the paid plan with enough requests:
Expected behavior on the paid plan without enough requests and with a logo history
Expected behavior on the paid plan without enough requests and without a logo history
logo-history-SITE_ID
key on the local storageTest it on a Jetpack site and a Simple site.
Simulating the tiers
Use the following snippets on your
0-sandbox.php
file to simulate you are using different tiers.Free plan:
Paid plan with enough requests:
Paid plan without enough requests:
Remember to sandbox the
public-api
URL on your testing machine.