Protect: Remove manual scan messaging from history view #38626

nateweller · 2024-07-30T19:32:19Z

Proposed changes:

Moves the manual scan message into the /scan route, so it will not be shown on the history page.
Updates the <ScanButton> component to accept custom variant and children props, so it can be used in the manual scan blurb.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#38117

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Validate the manual scan message is shown under the scanner threats list
Validate the manual scan message is not shown under the history threats list
Validate the scan buttons on the page continue to function as expected

Screenshots

github-actions · 2024-07-30T19:33:46Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

dkmyta

Nicely done!

…38626)

…38815) * Add TypeScript support to Jetpack Protect * Downgrade typescript to 5.0.4, to match other monorepo projects * Add TypeScript support to Jetpack Protect * Init feature branch * Protect: Add Scan_History class (#37903) * Protect: Add Scan History UI (#37988) * changelog * Protect: Separate scanner and history views via React Router and UI adjustments (#38325) * Run ./tools/fixup-project-versions.sh * Restore project versions * Run ./tools/fixup-project-versions.sh * Remove todo comment (#38628) * Fix History error state, add access points, and fix hidden filters (#38656) * Only display the manual scan message under the scanner threats list (#38626) * Protect: Add unignore threat capabilities (#38094) * Add Scan_History class * changelog * Update changelog * Merge trunk, fix versions * Add initial UI for scan history * Add firstDetected and fixedOn details to threat cards * Fix ignored message * Fix console error * Adjust wording and styles * Optimize * Fix firstDetected and fixedOn property retrieval issues, add todos * Remove unneeded ref * Consolidate scan history UI to existing components * Remove todos * Return false for scanHistory when upgrade is missing * Manage ScanPage states when viewing history * Move source data logic to useProtectData hook * Improve Summary component Button logic * ScanPage refactoring * Reapply missing scanIsUnavailable check * Add comments * Hide ignore when viewing threats, and clear history cache when updating or fixing * Add unignore actions and conditional handling to the UI * Add null coalescing to core threat prop assignment * Fix core threat normalization * Optimizations and refactoring * Revert standarization, and use conditionals * Add dummy arg to avoid bad translation minification * Changlog entry * Move viewingScanHistory out of initial state * Use threat status over lack of fixedOn to display unignore button * Add foundation for unignore request * Remove need for signature_id * Add TypeScript support to Jetpack Protect * Downgrade typescript to 5.0.4, to match other monorepo projects * Add TypeScript support to Jetpack Protect * Init feature branch * Protect: Add Scan_History class (#37903) * Protect: Add Scan History UI (#37988) * Init feature branch * Init feature branch * Init feature branch * Use react router for threat history, separate scan and history root components, minor UI adjustments * changelog * Add dummy args to avoid bad minification * Hide scan section navigation when user has no plan * Wrap ScanButton with forwardRef * Add onboarding popover to Scan Now button in empty state * Fix filtering of core threat history * Redirect to /scan from /scan/history when user has no plan * Fix animation glitch in onboarding popover * Remove unnecessary additions * Further removals after failed base merge * More removals * Add todos * Use status to conditional render unignore action button * Move ignore/unignore actions to dedicated modals * Add TypeScript support to Jetpack Protect * Downgrade typescript to 5.0.4, to match other monorepo projects * Add TypeScript support to Jetpack Protect * Init feature branch * Protect: Add Scan_History class (#37903) * Protect: Add Scan History UI (#37988) * changelog * Protect: Separate scanner and history views via React Router and UI adjustments (#38325) * Run ./tools/fixup-project-versions.sh * Restore project versions * Run ./tools/fixup-project-versions.sh * Remove todo comment (#38628) * Remove changelog * Display fix threat button only for current threats * Further unification * Refresh scan history after unignore * Update projects/plugins/protect/src/js/components/unignore-threat-modal/index.jsx Co-authored-by: Nate Weller <[email protected]> * Fix lint errors --------- Co-authored-by: Nate Weller <[email protected]> Co-authored-by: Nate Weller <[email protected]> * Do not show scan error when optimistically scanning (#38703) * Refactor useProtectData hook (#38637) * Fixup project versions * Update deactivation method to delete relevant options * changelog * Simplify * Remove changelog entries * Remove changelog entries * Remove changelog entries * changelog * Revert unintended Jetpack changes --------- Co-authored-by: Nate Weller <[email protected]> Co-authored-by: Nate Weller <[email protected]>

Only display the manual scan message under the scanner threats list

69c9908

nateweller requested a review from a team July 30, 2024 19:32

nateweller self-assigned this Jul 30, 2024

nateweller added the [Status] Needs Team Review label Jul 30, 2024

github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label Jul 30, 2024

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 30, 2024

dkmyta approved these changes Jul 30, 2024

View reviewed changes

dkmyta mentioned this pull request Aug 1, 2024

Protect: Add Threat History #38117

Merged

3 tasks

nateweller merged commit aa4673e into add/protect-threat-history Aug 1, 2024
50 of 51 checks passed

nateweller deleted the remove/protect/manual-scan-from-history branch August 1, 2024 21:18

github-actions bot removed [Status] Needs Team Review [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 1, 2024

nateweller added a commit that referenced this pull request Aug 1, 2024

Only display the manual scan message under the scanner threats list (#…

ef2b246

…38626)

nateweller added a commit that referenced this pull request Aug 4, 2024

Only display the manual scan message under the scanner threats list (#…

92949ab

…38626)

nateweller added a commit that referenced this pull request Aug 6, 2024

Only display the manual scan message under the scanner threats list (#…

3d1ae41

…38626)

nateweller added a commit that referenced this pull request Aug 8, 2024

Only display the manual scan message under the scanner threats list (#…

ea092fa

…38626)

nateweller added a commit that referenced this pull request Aug 9, 2024

Only display the manual scan message under the scanner threats list (#…

ae36f16

…38626)

nateweller added a commit that referenced this pull request Aug 9, 2024

Only display the manual scan message under the scanner threats list (#…

943d66f

…38626)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Protect: Remove manual scan messaging from history view #38626

Protect: Remove manual scan messaging from history view #38626

nateweller commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

dkmyta left a comment

Protect: Remove manual scan messaging from history view #38626

Protect: Remove manual scan messaging from history view #38626

Conversation

nateweller commented Jul 30, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Screenshots

github-actions bot commented Jul 30, 2024

dkmyta left a comment

Choose a reason for hiding this comment