Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Fix global stats type check #38634

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Protect: Fix global stats type check #38634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a241165
Fix global_stats type check
dkmyta Jul 30, 2024
1eea9c8
changelog
dkmyta Jul 30, 2024
246077a
Fix type check
dkmyta Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/waf/changelog/fix-protect-global-stats-type-check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fix global stats type check
4 changes: 2 additions & 2 deletions projects/packages/waf/src/class-waf-stats.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ public static function get_global_stats( $refresh_from_wpcom = false ) {
$global_stats = self::get_global_stats_from_options();
}

// Ensure that $global_stats is the correct type
if ( ! is_array( $global_stats ) && ! ( $global_stats instanceof \WP_Error ) ) {
// Ensure that $global_stats is of the correct type
if ( ( ! is_object( $global_stats ) && ! ( $global_stats instanceof \WP_Error ) ) ) {
return new \WP_Error( 'unexpected_type', 'Unexpected type or null returned for global stats' );
}

Expand Down
Loading