Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site-Level User Profile: Show links back to WordPress.com on profile.php #38638

Merged
merged 11 commits into from
Aug 6, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Jul 31, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/8421

Proposed changes:

This PR shows links back to WordPress.com for them to manage their WordPress.com profile.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Simple Classic & Default

  • If you test Simple Default sites, set wpcom_site_level_user_profile option 1
  • Go to /wp-admin/profile.php
  • Observe "Contact Info > Email" is disabled and has a link to /me/account
    Screenshot 2024-07-31 at 15 27 03
  • Observe "Account Management > New Password" has a link to /me/security
    Screenshot 2024-07-31 at 15 32 14

Atomic Classic

  • Go to /wp-admin/profile.php
  • Observe "Contact Info > Email" has a link to /me/account
    Screenshot 2024-07-31 at 15 25 50
  • Observe "Account Management > New Password" has a link to /me/security
    Screenshot 2024-07-31 at 15 26 01

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/profile-link-towpcom branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/profile-link-towpcom
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen daily.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@okmttdhr okmttdhr changed the title Site-Level User Profile: Show links back to WordPress.com for them to manage their WordPress.com profile Site-Level User Profile: Show links back to WordPress.com on profile.php Jul 31, 2024
@okmttdhr okmttdhr marked this pull request as ready for review July 31, 2024 08:08
@okmttdhr okmttdhr requested review from a team July 31, 2024 08:08
@okmttdhr okmttdhr self-assigned this Jul 31, 2024
@fushar
Copy link
Contributor

fushar commented Aug 4, 2024

Will review this first thing today.

@fushar fushar self-assigned this Aug 5, 2024
@fushar
Copy link
Contributor

fushar commented Aug 5, 2024

I added a couple commits to use existing Core's <p class="description" rather than custom styles. This simplifies the code a lot. I also updated the JS from #38519 to use the same way, cc: @DustyReagan.

fushar
fushar previously approved these changes Aug 5, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks good in all cases:

Contact Info

Simple Atomic
image image

Account Management

Simple Atomic
image image

@fushar
Copy link
Contributor

fushar commented Aug 5, 2024

@okmttdhr, note that I removed the email description on Simple Classic:

image

while testing, I found that the wording is confusing: it says "If you change this" but the field itself can't be changed.

@okmttdhr
Copy link
Member Author

okmttdhr commented Aug 6, 2024

@okmttdhr, note that I removed the email description on Simple Classic:
while testing, I found that the wording is confusing: it says "If you change this" but the field itself can't be changed.

Make sense :) Thank you for your work on this PR!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 6, 2024
@github-actions github-actions bot added [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Aug 6, 2024
@okmttdhr okmttdhr requested a review from fushar August 6, 2024 02:49
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and it still works fine.

@okmttdhr okmttdhr merged commit 065013c into trunk Aug 6, 2024
54 checks passed
@okmttdhr okmttdhr deleted the add/profile-link-towpcom branch August 6, 2024 04:19
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants