-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site-Level User Profile: Show links back to WordPress.com on profile.php #38638
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
…ection has child elements
Will review this first thing today. |
I added a couple commits to use existing Core's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okmttdhr, note that I removed the email description on Simple Classic: while testing, I found that the wording is confusing: it says "If you change this" but the field itself can't be changed. |
Make sense :) Thank you for your work on this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested and it still works fine.
Fixes https://github.com/Automattic/dotcom-forge/issues/8421
Proposed changes:
This PR shows links back to WordPress.com for them to manage their WordPress.com profile.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Simple Classic & Default
wpcom_site_level_user_profile
option 1/wp-admin/profile.php
Atomic Classic
/wp-admin/profile.php