Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/my jetpack product card copy #38648

Merged
merged 9 commits into from
Aug 5, 2024

Conversation

jboland88
Copy link
Contributor

@jboland88 jboland88 commented Jul 31, 2024

Proposed changes:

  • This diff updates the product descriptions on My Jetpack to be a bit better at describing what the product is going to do.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Create a new test site with this PR
  • Run the welcome flow to get recommendations. Confirm that product descriptions are showing on the recommendation cards.
  • Confirm the updated descriptions are showing on product cards elsewhere as well.

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/my-jetpack-product-card-copy branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/my-jetpack-product-card-copy
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@jboland88 jboland88 force-pushed the update/my-jetpack-product-card-copy branch from 55e801c to cb2dd64 Compare August 3, 2024 19:27
@jboland88 jboland88 marked this pull request as ready for review August 3, 2024 19:53
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good, just a minor nitpick and we should be good to ship 🚢

projects/packages/my-jetpack/src/products/class-boost.php Outdated Show resolved Hide resolved
Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jboland88 jboland88 merged commit 9708a16 into trunk Aug 5, 2024
70 checks passed
@jboland88 jboland88 deleted the update/my-jetpack-product-card-copy branch August 5, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants