-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: add A/B experiment to welcome flow #38664
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
8300c70
to
c4ba82c
Compare
bc724cd
to
4e0579f
Compare
4e0579f
to
a6791c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone ahead and made some adjustments, but in general code looks good, imo ready to ship!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged and resolved conflicts after Tracks PR merge (#38641)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise this looks good - clever solution to sideload tracks after the site connection.
The test worked as described - nice work.
The main question I had was whether we should send the user straight into the user connection flow for control. Not a blocker though.
projects/packages/my-jetpack/_inc/components/welcome-flow/ConnectionStep.tsx
Outdated
Show resolved
Hide resolved
projects/packages/my-jetpack/_inc/components/welcome-flow/ConnectionStep.tsx
Outdated
Show resolved
Hide resolved
projects/packages/my-jetpack/_inc/components/welcome-flow/ConnectionStep.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, tested according to plan.
I tested without sandboxing the API to simulate a "broken" request where no assignments were received and it defaulted to control as expected.
Context: pbxNRc-3UJ-p2
Proposed changes:
side-load-tracks.ts
.For more context about the experiment, see the P2 post linked above.
Other information:
Jetpack product discussion
pbxNRc-3UJ-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
/wp-admin/options-general.php?page=companion_settings
and point JETPACK__SANDBOX_DOMAIN to your WPCOM sandboxassignment
and confirm you see a response like this: