Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Add preview modal analytics #38714

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Conversation

gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented Aug 5, 2024

Fixes https://github.com/Automattic/jetpack-reach/issues/452

Proposed changes:

  • Added tracking for the modal opening c04c0b2
  • Added tracking for the connection toggles 336db6d
  • Added tracking for adding custom media and changing the custom message 9adf756

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-reach/issues/452

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Go to the post editor with this change
  • Open browser console and run localStorage.setItem('debug', 'dops:analytics');

Opening the preview modal

  • Open the preview modal
  • You should see it being logged in the console
    image

Toggling connections

  • Toggle a connection from the editor.
  • You should see it being logged as jetpack_social_connection_toggled with prop {location: 'editor'}
  • Now toggle a connection from the preview modal, in the right bottom side with the toggle
  • You should see the same event, but with the location of preview-modal.

Attaching media

  • Attach a custom media from the editor.
  • You should see the event appearing in the logs, but only when a media is attached and not removed.
  • Do the same from the modal. Check the props, it should reflect the correct place.

Editing the custom message

  • Change the custom message from the editor.
  • A tracking event should get logged the first time the textarea is edited. This is needed so we do not spam tracks for each character change.
  • Do the same from the modal. Check the props, it should reflect the correct place.

Check events on Tracks.

  • Wait ~10 minutes.
  • Goto MC Live tracking
  • Check the events there, and check the props. It should reflect what you saw in the logs before

Events to check:

  • jetpack_social_connection_toggled
  • jetpack_social_media_attached
  • jetpack_social_custom_message_changed
  • jetpack_social_preview_modal_opened

@gmjuhasz gmjuhasz requested a review from a team August 5, 2024 11:14
@gmjuhasz gmjuhasz self-assigned this Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/social-preview-modal-analytics branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/social-preview-modal-analytics
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@gmjuhasz gmjuhasz changed the title Add/social preview modal analytics Social: Add preview modal analytics Aug 5, 2024
manzoorwanijk
manzoorwanijk previously approved these changes Aug 5, 2024
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

image

…l-post-modal/preview-section.tsx

Co-authored-by: Manzoor Wani <[email protected]>
@gmjuhasz gmjuhasz merged commit 51e5961 into trunk Aug 5, 2024
58 checks passed
@gmjuhasz gmjuhasz deleted the add/social-preview-modal-analytics branch August 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants