-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Administration Email in General Settings #38722
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Since this only applies to Simple sites, decided to move this code to D157605-code |
Fixes https://github.com/Automattic/dotcom-forge/issues/8518
Proposed changes:
:has
CSS selector to target thetr
row containing the email address option, as this row lacks distinctive attributes for simpler selection. The:has
selector offers a straightforward and effective method, but its drawback is the lack of support in some older browsers. As a contingency, this PR directly hides the individual email address elements, which results in some residual whitespace due to the row itself not being removed. To address this, JavaScript is employed as a secondary fallback to eliminate thetr
row and its associated whitespace.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
:has
by testing on an unsupported browser. Or alternatively, you can edit this code locally, commenting out the:has
CSS, and then building and uploading this code to your sandbox using the commandjetpack build packages/jetpack-mu-wpcom plugins/mu-wpcom-plugin
andjetpack rsync mu-wpcom-plugin [yoursandbox]:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/production
, as documented in the Field Guide. PCYsg-Osp-p2