Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Administration Email in General Settings #38722

Closed
wants to merge 8 commits into from

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Aug 5, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/8518

Proposed changes:

  • This PR hides the Administration Email field in General Settings on Simple Classic sites.
  • Importantly, this PR utilizes the :has CSS selector to target the tr row containing the email address option, as this row lacks distinctive attributes for simpler selection. The :has selector offers a straightforward and effective method, but its drawback is the lack of support in some older browsers. As a contingency, this PR directly hides the individual email address elements, which results in some residual whitespace due to the row itself not being removed. To address this, JavaScript is employed as a secondary fallback to eliminate the tr row and its associated whitespace.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Apply this PR to your sandbox using the instructions in the comment below.
  • Go to /wp-admin/options-general.php on a Simple Classic site and view that the Administration Email field is NOT visible.
  • You can test the fallback to :has by testing on an unsupported browser. Or alternatively, you can edit this code locally, commenting out the :has CSS, and then building and uploading this code to your sandbox using the command jetpack build packages/jetpack-mu-wpcom plugins/mu-wpcom-plugin and jetpack rsync mu-wpcom-plugin [yoursandbox]:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/production, as documented in the Field Guide. PCYsg-Osp-p2
  • Apply this PR to an Atomic site using the Jetpack Beta plugin and the instructions in the comment below.
  • Go to /wp-admin/options-general.php on your Atomic Classic test site and view that the Administration Email field is visible.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/general-options-email branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin remove/general-options-email
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen daily.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 5, 2024
@DustyReagan DustyReagan requested a review from a team August 5, 2024 18:06
@DustyReagan DustyReagan self-assigned this Aug 5, 2024
@DustyReagan DustyReagan added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 5, 2024
@DustyReagan DustyReagan changed the title Remove/general options email Remove Administration Email in General Settings Aug 5, 2024
@github-actions github-actions bot added [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Aug 5, 2024
@DustyReagan
Copy link
Member Author

Since this only applies to Simple sites, decided to move this code to D157605-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant