Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPCOM plan name revert: Update i18n #38726

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

niranjan-uma-shankar
Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar commented Aug 6, 2024

Proposed changes:

Does this pull request change what data or activity we track or use?

No

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@niranjan-uma-shankar niranjan-uma-shankar marked this pull request as ready for review August 6, 2024 09:30
@niranjan-uma-shankar niranjan-uma-shankar self-assigned this Aug 6, 2024
@niranjan-uma-shankar niranjan-uma-shankar changed the title Fix/i18n wpcomsh WPCOM plan name revert: Update i18n Aug 6, 2024
yuliyan
yuliyan previously approved these changes Aug 6, 2024
Copy link
Member

@yuliyan yuliyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niranjan-uma-shankar niranjan-uma-shankar merged commit c189085 into trunk Aug 6, 2024
53 checks passed
@niranjan-uma-shankar niranjan-uma-shankar deleted the fix/i18n-wpcomsh branch August 6, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants