Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpcomsh: Update POT file #38728

Merged
merged 1 commit into from
Aug 6, 2024
Merged

wpcomsh: Update POT file #38728

merged 1 commit into from
Aug 6, 2024

Conversation

yuliyan
Copy link
Member

@yuliyan yuliyan commented Aug 6, 2024

Fixes #

Proposed changes:

  • Update wpcomsh POT file with make i18n.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Check updated POT file.

@yuliyan yuliyan added [Focus] i18n Internationalization / i18n, adaptation to different languages [Plugin] Wpcomsh labels Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Wpcomsh plugin:

  • Next scheduled release: on demand (usually Mondays if not sooner).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 6, 2024
@yuliyan yuliyan changed the title Update/wpcomsh update i18n wpcomsh: Update POT file Aug 6, 2024
@yuliyan yuliyan changed the title wpcomsh: Update POT file wpcomsh: Update POT and translation files Aug 6, 2024
@yuliyan yuliyan force-pushed the update/wpcomsh-update-i18n branch from ead06dc to 5eac3f0 Compare August 6, 2024 10:53
@yuliyan yuliyan changed the title wpcomsh: Update POT and translation files wpcomsh: Update POT file Aug 6, 2024
@niranjan-uma-shankar niranjan-uma-shankar added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 6, 2024
Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuliyan yuliyan merged commit 85681ea into trunk Aug 6, 2024
55 checks passed
@yuliyan yuliyan deleted the update/wpcomsh-update-i18n branch August 6, 2024 11:21
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] i18n Internationalization / i18n, adaptation to different languages [Plugin] Wpcomsh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants