Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: lossless image optimization, part 3 #38750

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

danluu
Copy link
Contributor

@danluu danluu commented Aug 7, 2024

This is a continuation of #38398 and #38573, which has been split into multiple parts to avoid hitting the wpcom size limit, which happened on Automattic/themes#7671. Please see #38398 for more details and context.

As a rough estimate for size of files touch that go into wpcom, we have

% git diff --name-only | grep -v "w.org-assets" | xargs du -ch  
5.8M    total 

#38573 had some instructions for getting a better estimate on wpcom sizes. I can try that and add a comment about that in a bit.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Can test via imagemagick compare or by eyeballing the images to check that they don't appear to have visually changed.

@danluu danluu added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the try/lossless-image-optmization-part-3 branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack try/lossless-image-optmization-part-3
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin try/lossless-image-optmization-part-3
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

matticbot pushed a commit to Automattic/jetpack-stats that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-transport-helper that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-yoast-promo that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-boost-core that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-boost-speed-score that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-sync that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-import that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-licensing that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-waf that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-protect-status that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/scheduled-updates that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-explat that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-jitm that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-stats-admin that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-publicize that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-blaze that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-wordads that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-forms that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-storybook that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-masterbar that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-my-jetpack that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-backup that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-mu-wpcom that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-videopress that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
matticbot pushed a commit to Automattic/jetpack-search that referenced this pull request Aug 19, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in Automattic/jetpack#38750 (review) for more info on why that image was skipped.

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/10459545444

Upstream-Ref: Automattic/jetpack@8510521
anomiex added a commit that referenced this pull request Aug 20, 2024
There are many interesting ways SVGs can be used. The optimizations
broke some of these (see #38966). To be safe, let's revert them all.
anomiex added a commit that referenced this pull request Aug 20, 2024
There are many interesting ways SVGs can be used. The optimizations
broke some of these (see #38966). To be safe, let's revert them all.
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
Lossless image optimization of Jetpack images.

This is a continuation of #38398 and #38573. Please see #38398 for more context and details.

This finishes this series of commits. All images except for projects/js-packages/connection/components/disconnect-dialog/images/disconnect-thanks.jpg have been optimized. See @anomiex's debugging of the problem in #38750 (review) for more info on why that image was skipped.
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
There are many interesting ways SVGs can be used. The optimizations
broke some of these (see #38966). To be safe, let's revert them all.
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
There are many interesting ways SVGs can be used. The optimizations
broke some of these (see #38966). To be safe, let's revert them all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Test Results to Slack Actions GitHub actions used to automate some of the work around releases and repository management [Feature] Contact Form [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Theme Tools [JS Package] AI Client [JS Package] Components [JS Package] Connection [JS Package] Licensing [JS Package] Publicize Components [JS Package] Social Logos [JS Package] Storybook [mu wpcom Feature] Wpcom Global Styles [mu wpcom Feature] Wpcom Plugins [mu wpcom Feature] Wpcom Themes [Package] Backup [Package] Classic Theme Helper [Package] Forms [Package] Image CDN [Package] Jetpack mu wpcom WordPress.com Features [Package] Jitm [Package] Masterbar [Package] My Jetpack [Package] VideoPress [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants