Newsletter: Email preview: Access Selector improvementes

[lezama]

Proposed changes:

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply D157745-code.
• Sync this branch to your sandbox.
• Point JETPACK__SANDBOX_DOMAIN to your sandbox.
• Add paywall block.
• Use different combinations of post access and preview access.
• Set the feature flag by adding &showNewsletterMenu to the url.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/email-preview-access-selector branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/email-preview-access-selector
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[crisbusquets]

Hi @lezama !

I tried to test it, but I was unable to create a JN site. @jeherve helped me with the debugging (Slack thread: p1723016472631529-slack-CDLH4C1UZ), here's the debug file:

debug.txt

[lezama]

@crisbusquets I think I fixed the issue you were seeing, it's ready for review again, but don't look at design just yet! Will do a proper Design iteration once functionality is working 😄

I am tracking what's still missing on a TODO list here

[enejb]

Nice work.
I think in a follow up PR we should deal with cases where the post is set to not send emails since this makes it so that we currently can't show a preview.

[jeherve]

To use those experimental APIs, you would need to add linting exceptions:

Suggested change

	__experimentalToggleGroupControl as ToggleGroupControl,
	__experimentalToggleGroupControlOption as ToggleGroupControlOption,
	__experimentalToggleGroupControlOptionIcon as ToggleGroupControlOptionIcon,
	__experimentalToggleGroupControl as ToggleGroupControl, // eslint-disable-line @wordpress/no-unsafe-wp-apis
	__experimentalToggleGroupControlOption as ToggleGroupControlOption, // eslint-disable-line @wordpress/no-unsafe-wp-apis
	__experimentalToggleGroupControlOptionIcon as ToggleGroupControlOptionIcon, // eslint-disable-line @wordpress/no-unsafe-wp-apis

Since those may not be available depending on the site's version of Gutenberg / core installed, I would recommend adding a fallback to ensure no errors, when ToggleGroupControl, ToggleGroupControlOption, or ToggleGroupControlOptionIcon do not exist. You can check

jetpack/projects/plugins/jetpack/extensions/shared/components/ai-model-selector-control/index.tsx

Lines 36 to 40 in 0bc9ec9

	/*
	* Add a fallback for the ToggleGroupControlOption component,
	* since it is experimental and might not be available in all versions of Gutenberg.
	*/
	if ( ! ToggleGroupControlOption || ! ToggleGroupControl ) {

for an example.