-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact Form: Removing deprecated Google Drive Helper file, and jetpack_form_register_pattern function #38786
Conversation
…dating phan baseline
…dating phan baseline
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Fixes https://github.com/Automattic/vulcan/issues/306
Proposed changes:
Other information:
Jetpack product discussion
https://github.com/Automattic/vulcan/issues/306
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
No functionality should be affected as we're removing deprecated files/functions.
However, we can confirm Contact Forms work as expected.
We can also confirm the Form inbox connects to Google drive as expected
/wp-admin/admin.php?page=jetpack-forms
- make sure you select 'Inbox' from the 'View' tab (top right of the dashboard). You'll need some form entries, then you can click on 'Export' and select 'Google Sheets'.Nothing should be showing in error logs either.