Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form: Removing deprecated Google Drive Helper file, and jetpack_form_register_pattern function #38786

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

coder-karen
Copy link
Contributor

@coder-karen coder-karen commented Aug 8, 2024

Fixes https://github.com/Automattic/vulcan/issues/306

Proposed changes:

  • This PR cleans up after deprecations related to the Contact Form module in Jetpack (removing a deprecated function and the Jetpack_Google_Drive_Helper class, both of which have working alternatives in the Contact Form package).

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/306

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

No functionality should be affected as we're removing deprecated files/functions.

However, we can confirm Contact Forms work as expected.

We can also confirm the Form inbox connects to Google drive as expected /wp-admin/admin.php?page=jetpack-forms - make sure you select 'Inbox' from the 'View' tab (top right of the dashboard). You'll need some form entries, then you can click on 'Export' and select 'Google Sheets'.

Nothing should be showing in error logs either.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/google-drive-helper branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack remove/google-drive-helper
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@coder-karen coder-karen marked this pull request as ready for review August 8, 2024 15:11
@coder-karen coder-karen requested a review from a team August 8, 2024 15:11
@coder-karen coder-karen added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Aug 8, 2024
@jeherve jeherve added [Feature] Contact Form [Status] Ready to Merge Go ahead, you can push that green button! [Type] Janitorial [Pri] Low and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 8, 2024
@coder-karen coder-karen merged commit d1a9ad5 into trunk Aug 9, 2024
63 of 64 checks passed
@coder-karen coder-karen deleted the remove/google-drive-helper branch August 9, 2024 07:01
@github-actions github-actions bot added this to the jetpack/13.8 milestone Aug 9, 2024
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants