Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: Add Support Links for Recent Blocks #38794

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented Aug 8, 2024

Fixes Automattic/wp-calypso#93391
Fixes Automattic/wp-calypso#93387
Fixes Automattic/wp-calypso#93284

Proposed changes:

  • Adds the support doc links for the Goodreads, Top Posts and Pages, and Blog Stats block.

Jetpack product discussion

N/A.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

I'm having issues building the plugin, so I haven't actually been able to test this. Once the plugin has been built though, you should theoretically be able to see a link to the support document under the description for the Blog Stats, Goodreads, and Top Posts and Pages block, which should appear in the block sidebar. Verify that all of these links are correct.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


@github-actions github-actions bot added the OSS Citizen This Pull Request was opened by an Open Source contributor. label Aug 8, 2024
@anomiex anomiex added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 13, 2024
@coder-karen coder-karen force-pushed the update/blocks-support-links branch from 9523785 to 03a638f Compare August 19, 2024 10:38
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, thank you for adding these!

@coder-karen coder-karen added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 19, 2024
@coder-karen coder-karen merged commit d4cdc44 into Automattic:trunk Aug 19, 2024
56 checks passed
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[mu wpcom Feature] Wpcom Block Description Links OSS Citizen This Pull Request was opened by an Open Source contributor. [Package] Jetpack mu wpcom WordPress.com Features
Projects
None yet
3 participants