Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stat trends for videopress my jetpack card #38868

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Aug 13, 2024

Proposed changes:

Add stat trends for the value indicators on the VideoPress card in My Jetpack

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: p1HpG7-rb7-p2

Does this pull request change what data or activity we track or use?

Yes, a prop for previous stats is added to the tracks that are tracked when the tooltip is clicked

Testing instructions:

  1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
  2. Make sure your site has at least one video
  3. To mock some randomized data, go to fbhepr%2Skers%2Sjcpbz%2Schoyvp.ncv%2Serfg%2Sjcpbz%2Qwfba%2Qraqcbvagf%2Spynff.jcpbz%2Qwfba%2Qncv%2Qfgngf%2Qivqrb%2Qcynlf%2Qi1%2Q1%2Qraqcbvag.cuc%3Se%3Q210o65nn%26zb%3Q1199%26sv%3Q37%2350-og and replace all those zeros with something like rand(0, 100). You can pick whatever numbers you'd like if you wanted to test out smaller or bigger numbers.
  4. Go to My Jetpack and make sure the stat trends are shown and look good on all screen sizes
    image

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/stat-trends-for-videopress-my-jetpack branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/stat-trends-for-videopress-my-jetpack
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 13, 2024
@ilonagl
Copy link

ilonagl commented Aug 13, 2024

It looks good, @CodeyGuyDylan!
Group 1-11

I wonder if there is a way to have this at the same line (red line reference)?

@CodeyGuyDylan CodeyGuyDylan force-pushed the add/tooltip-for-videopress-card branch from cd13c12 to 9563f26 Compare August 14, 2024 21:53
@CodeyGuyDylan
Copy link
Contributor Author

It looks good, @CodeyGuyDylan! Group 1-11

I wonder if there is a way to have this at the same line (red line reference)?

I think this is possible. The reason for it is the arrow is slightly larger than the text pixel-wise. This is to keep the size of the arrow consistent with where we are using it elsewhere. However I should be able to just increase the line-height of the text and I think that will fix it 😄

@CodeyGuyDylan CodeyGuyDylan force-pushed the add/stat-trends-for-videopress-my-jetpack branch 2 times, most recently from 9f0a327 to d69c72e Compare August 14, 2024 22:22
@CodeyGuyDylan CodeyGuyDylan force-pushed the add/tooltip-for-videopress-card branch from a3ecd1b to 8374b91 Compare August 15, 2024 16:48
@CodeyGuyDylan CodeyGuyDylan force-pushed the add/stat-trends-for-videopress-my-jetpack branch from d69c72e to e212415 Compare August 15, 2024 17:00
Base automatically changed from add/tooltip-for-videopress-card to trunk August 16, 2024 16:42
@CodeyGuyDylan CodeyGuyDylan force-pushed the add/stat-trends-for-videopress-my-jetpack branch from e212415 to fa2e260 Compare August 16, 2024 17:10
Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works good, just as described. Code looks all good, I don't see any issues.
LGTM! 👍

@CodeyGuyDylan CodeyGuyDylan merged commit 290118d into trunk Aug 19, 2024
71 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the add/stat-trends-for-videopress-my-jetpack branch August 19, 2024 15:35
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 19, 2024
pkuliga pushed a commit that referenced this pull request Aug 23, 2024
* Add tooltip for installed with no videos

* Add tooltip for inactive with videos

* Add tooltips for active states

* Update tooltip location when videos are present but plugin is inactive

* Move info tooltip to heading

* Move info tooltip to heading

* Update definition of videopress active

* Simplify logic of videopress value section

* Add stats trends

* Add changelog

* Adjust placement of arrow

* Re-add period
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants