-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stat trends for videopress my jetpack card #38868
Add stat trends for videopress my jetpack card #38868
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
It looks good, @CodeyGuyDylan! I wonder if there is a way to have this at the same line (red line reference)? |
cd13c12
to
9563f26
Compare
I think this is possible. The reason for it is the arrow is slightly larger than the text pixel-wise. This is to keep the size of the arrow consistent with where we are using it elsewhere. However I should be able to just increase the line-height of the text and I think that will fix it 😄 |
9f0a327
to
d69c72e
Compare
a3ecd1b
to
8374b91
Compare
d69c72e
to
e212415
Compare
e212415
to
fa2e260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works good, just as described. Code looks all good, I don't see any issues.
LGTM! 👍
* Add tooltip for installed with no videos * Add tooltip for inactive with videos * Add tooltips for active states * Update tooltip location when videos are present but plugin is inactive * Move info tooltip to heading * Move info tooltip to heading * Update definition of videopress active * Simplify logic of videopress value section * Add stats trends * Add changelog * Adjust placement of arrow * Re-add period
Proposed changes:
Add stat trends for the value indicators on the VideoPress card in My Jetpack
Other information:
Jetpack product discussion
P2: p1HpG7-rb7-p2
Does this pull request change what data or activity we track or use?
Yes, a prop for previous stats is added to the tracks that are tracked when the tooltip is clicked
Testing instructions:
rand(0, 100)
. You can pick whatever numbers you'd like if you wanted to test out smaller or bigger numbers.