-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social: Hide share status when no connection is enabled #39120
Social: Hide share status when no connection is enabled #39120
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
4a3bb0d
to
d7efe41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
The only outlier is when Instagram is disabled automatically when no featured image set. It works well when featured image is set and the connection is disabled by the user. We can live with that edge case.
* Create usePostPrePublishValue hook * Extract re-usable test logic to common utilities * Add tests for usePostPrePublishValue * Add changelog * Make CI happy * Social: Hide share status when no connection is enabled
Currently, even if all the connections are disabled, we still show,
"Sharing to your social media…"
message, which is not ideal.We don't need to show that status if all the connections are disabled.
This PR uses the hook added in #39119.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
define( 'JETPACK_SOCIAL_HAS_SHARE_STATUS', true );