-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Add fixer status to initial state #39125
Conversation
changelog changelog
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
cfe4e3b
to
b510e1e
Compare
b510e1e
to
e95fe37
Compare
changelog changelog
e95fe37
to
4eac461
Compare
4eac461
to
d5a02c8
Compare
160323a
to
a294482
Compare
a294482
to
06dfbb4
Compare
projects/plugins/protect/src/js/data/scan/use-fixers-mutation.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Description
Retrieve status of all fixable threats in the initial state
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpackProtectInitialState
and verify that:status.fixable_threat_ids
is set to the default empty arrayfixerStatus
isfalse
as an upgrade is required to retrieve the fixer status datajetpackProtectInitialState
and verify that:status.fixable_threat_ids
is populated with the IDs for the fixable threats that scan identifiedfixerStatus
is stillfalse
as a user connection is required to retrieve the fixer status datajetpackProtectInitialState
and verify that:status.fixable_threat_ids
is populated with the IDs for the fixable threats that scan identifiedfixerStatus
is populated with status of the IDs