Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Add fixer status to initial state #39125

Merged
merged 67 commits into from
Sep 16, 2024

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Aug 28, 2024

Description

Retrieve status of all fixable threats in the initial state

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch and start Jurassic Tube
  • From the browser dev console log out jetpackProtectInitialState and verify that:
    • status.fixable_threat_ids is set to the default empty array
    • fixerStatus is false as an upgrade is required to retrieve the fixer status data
  • Activate Protect and upgrade
  • Add fixable threats using the Debug Tool
  • Run the scan to identify the threats
  • From the browser dev console log out jetpackProtectInitialState and verify that:
    • status.fixable_threat_ids is populated with the IDs for the fixable threats that scan identified
    • fixerStatus is still false as a user connection is required to retrieve the fixer status data
  • Connect your user account
  • From the browser dev console log out jetpackProtectInitialState and verify that:
    • status.fixable_threat_ids is populated with the IDs for the fixable threats that scan identified
    • fixerStatus is populated with status of the IDs

@dkmyta dkmyta self-assigned this Aug 28, 2024
@github-actions github-actions bot added [Package] Protect Models [Package] Protect Status [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/protect-fixer-status-to-initial-state branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/protect-fixer-status-to-initial-state
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@nateweller nateweller force-pushed the add/protect/tanstack-query branch from cfe4e3b to b510e1e Compare August 28, 2024 18:58
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from b510e1e to e95fe37 Compare August 28, 2024 19:27
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from e95fe37 to 4eac461 Compare August 28, 2024 19:53
@github-actions github-actions bot added the Docs label Aug 28, 2024
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from 4eac461 to d5a02c8 Compare August 28, 2024 19:58
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from 160323a to a294482 Compare September 5, 2024 19:21
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from a294482 to 06dfbb4 Compare September 7, 2024 18:38
Base automatically changed from add/protect/tanstack-query to trunk September 9, 2024 16:51
@dkmyta dkmyta marked this pull request as ready for review September 9, 2024 17:46
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@nateweller nateweller merged commit bf5df64 into trunk Sep 16, 2024
71 checks passed
@nateweller nateweller deleted the add/protect-fixer-status-to-initial-state branch September 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs [Package] Protect Models [Package] Protect Status [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants