Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Change Jetpack AI product page limit handling #39129

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

CGastrell
Copy link
Contributor

Proposed changes:

Add a notice for unlimited plans over fair usage on Jetpack AI product page
Show current period request count alongside the already all time requests count on Jetpack AI product page
Remove unnecessary conditional to determine if user is on unlimited plan

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1724872002295049/1724866663.901329-slack-C054LN8RNVA

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Sandbox the public API. Disable the tier plans and set the licensed amount above the usage limit (refer to D159560-code for setting up an unlimited plan over limit).

Go to My Jetpack and user the "View" button on Jetpack AI card to get to the product page.
There should be new card showing current period request count
There should be a notice stating when the next period reset will happen and inviting to upgrade

Enabling tier plans again should show remaining requests (default) instead of current period usage.

Exception to unlimited plans: there should be no upgrade button.

…e for unlimited user going over fair usage. Add usage counter for unlimited plans for current period
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the change/jetpack-ai-product-page-limit-handling branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack change/jetpack-ai-product-page-limit-handling
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

@lhkowalski lhkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and is working nicely.

With tiers disabled, over the limit, I see this (both monthly and all time counter):

Screenshot 2024-08-29 at 12 04 56

Still with tiers disabled, but under the limit, I see this (the notice is gone, as expected):

Screenshot 2024-08-29 at 12 06 22

@CGastrell CGastrell merged commit 19db61b into trunk Aug 29, 2024
72 of 73 checks passed
@CGastrell CGastrell deleted the change/jetpack-ai-product-page-limit-handling branch August 29, 2024 16:09
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* fix condition for determining if user is on unlimited plan. Add notice for unlimited user going over fair usage. Add usage counter for unlimited plans for current period

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants