Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Initial state: Migrate useAdminUiV1 feature flag to script data #39137

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Aug 29, 2024

Extracted out of #38952, this PR migrates on the useAdminUiV1 feature flag and other feature flags will be migrated in the follow up PRs.

Proposed changes:

  • Migrate useAdminUiV1 feature flag to script data

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • On Simple and Atomic sites, goto post editor
  • Confirm that the editor loads fine
  • Confirm that the connection management links point to Calypso
  • For Jetpack sites, goto post editor
  • Confirm that connection management buttons open the new connection management UI
  • Goto Jetpack and Social admin page
  • Confirm that the connection buttons open the modal instead of pointing to calypso
  • Go to /wp-admin/admin.php?page=jetpack#/recommendations/publicize
  • Confirm that the CTA "View Jetpack Social settings" links to the social settings section
  • Goto /wp-admin/admin.php?page=jetpack#/recommendations/unlimited-sharing-activated
  • Confirm that the CTA points to the social settings section

@manzoorwanijk manzoorwanijk self-assigned this Aug 29, 2024
@github-actions github-actions bot added [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin Admin Page React-powered dashboard under the Jetpack menu RNA labels Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-initial-state-migrate-useadminuiv1-feature-flag branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-initial-state-migrate-useadminuiv1-feature-flag
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-initial-state-migrate-useadminuiv1-feature-flag
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@manzoorwanijk manzoorwanijk force-pushed the update/social-initial-state-migrate-useadminuiv1-feature-flag branch 2 times, most recently from e23e7b8 to bc934b9 Compare August 29, 2024 13:20
@manzoorwanijk manzoorwanijk force-pushed the update/social-initial-state-migrate-useadminuiv1-feature-flag branch from bc934b9 to 2208ab1 Compare August 29, 2024 13:23
@manzoorwanijk manzoorwanijk requested a review from a team September 16, 2024 04:20
Copy link
Contributor

@spsiddarthan spsiddarthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well!

@manzoorwanijk manzoorwanijk merged commit 6504c21 into trunk Sep 16, 2024
73 checks passed
@manzoorwanijk manzoorwanijk deleted the update/social-initial-state-migrate-useadminuiv1-feature-flag branch September 16, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants