Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable terser conditional optimization #39279

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

d-alleyne
Copy link
Contributor

Related to #39178 and p1725541249189489/1725538001.987329-slack-C74C3THK7

Proposed changes:

  • Disabled the conditional transformations in Terser to prevent breaking translatable strings
  • Updated the test snapshots to reflect the Terser configuration change.
  • Update the documentation to remove the workaround

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

This prevents optimizations such as converting:

condition ? __( 'true', 'domain' ) : __( 'false', 'domain' );

to

__( condition ? 'true' : 'false', 'domain' );

which is an invalid optimization for translatable strings
@d-alleyne d-alleyne requested a review from anomiex September 6, 2024 19:41
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the disable/terser-conditional-optimization branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack disable/terser-conditional-optimization
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin disable/terser-conditional-optimization
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 6, 2024
@d-alleyne d-alleyne merged commit a4050bf into trunk Sep 6, 2024
74 checks passed
@d-alleyne d-alleyne deleted the disable/terser-conditional-optimization branch September 6, 2024 20:14
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Sep 6, 2024
anomiex added a commit that referenced this pull request Sep 6, 2024
anomiex added a commit that referenced this pull request Sep 6, 2024
d-alleyne added a commit that referenced this pull request Sep 10, 2024
The initial PR targeted the entire Jetpack repo, and caused an
increase in the build size of the project. This PR targets the
jetpack-mu-wpcom package instead.
d-alleyne added a commit that referenced this pull request Sep 12, 2024
The initial PR targeted the entire Jetpack repo, and caused an
increase in the build size of the project. This PR targets the
jetpack-mu-wpcom package instead.
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* Disable optimization of conditionals

This prevents optimizations such as converting:

condition ? __( 'true', 'domain' ) : __( 'false', 'domain' );

to

__(o?'true':'false','domain' );

which is an invalid optimization for translatable strings

* changelog

* Update tests now that Terser's conditional optimization has been disabled

* changelog

* Remove documentation about unnecessary workaround
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant