Shortcode: Fix the youtube url cannot be embedded due to the trailing question mark of the youtube id

[arthur791004]

Fixes 8674608-zd-a8c. See p1725860629793219/1725499365.595119-slack-CRWCHQGUB fo more details.

Proposed changes:

• Remove the trailing question mark from the video id of the YouTube URL.
• I'm not sure whether there is any changes on the https://www.youtube.com/oembed?format=json&url=<youtube_url> endpoint but now the YouTube URL with the trailing question mark doesn't work and the endpoint returns 400 so that the URL cannot be embedded correctly. But it might also related to the following changes
  • The editor - The embed block converts to the paragraph block automatically instead of displaying the placeholder with the error message. As a result, the user understands that it cannot be embedded immediately
    
  • The frontend - Shortcode: Get rid of custom shortcodes for YouTube and Vimeo in favor of Core #39096 removed the custom handler for the YouTube URL so the paragraph block with the YouTube URL cannot be replaced with the embedded YouTube video. As a result, it displays the paragraph block on the frontend as well

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply changes to your site
• Create a new post
• Insert the YouTube Embed block with the following URL
  • https://www.youtube.com/watch?v=ax1csKKQnns?
• Make sure it can be embedded correctly

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/youtube-embed-trailing-question-mark branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/youtube-embed-trailing-question-mark
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jeherve]

This tests well for me with that specific video. What do you think about adding tests for this, to highlight why this is needed and ensure it doesn't break current behavior?

[arthur791004]

Sure! I'll add tests tomorrow, thank you!