Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sharing networks #39353

Closed
wants to merge 2 commits into from
Closed

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Sep 11, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/9178

Proposed changes:

This PR adds the following sharing networks:

  • Tumblr
  • LinkedIn
  • Pinterest
  • Email

Screenshot 2024-09-25 at 2 49 54 PM

The reason these networks are added is to match the ones from the now-deprecated Sharing modal:

image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply changes by following the instructions from Add more sharing networks #39353 (comment).
  • Head to Posts > Add New Post.
  • Publish a new post and ensure that the newly added networks are available.
  • Ensure that they work as intended.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-post-published-modal branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/remove-post-published-modal
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@taipeicoder taipeicoder self-assigned this Sep 24, 2024
@taipeicoder taipeicoder force-pushed the update/remove-post-published-modal branch from 3dd43eb to 02c485b Compare September 24, 2024 07:59
@taipeicoder taipeicoder changed the title Update/remove post published modal Add more sharing networks Sep 24, 2024
@taipeicoder taipeicoder force-pushed the update/remove-post-published-modal branch from d57e938 to 96237e8 Compare September 25, 2024 06:43
@taipeicoder taipeicoder marked this pull request as ready for review September 25, 2024 06:56
@taipeicoder taipeicoder requested a review from a team September 25, 2024 06:56
@taipeicoder taipeicoder added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review and removed [Status] In Progress labels Sep 25, 2024
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That manual sharing is to provide an alternative for the networks that we don't support in publicize/social yet/anymore.

So, we need to think/discuss which networks we want to include here. We also don't want to take up too much real estate in that sidebar

@manzoorwanijk manzoorwanijk added the DO NOT MERGE don't merge it! label Sep 26, 2024
@taipeicoder
Copy link
Contributor

That manual sharing is to provide an alternative for the networks that we don't support in publicize/social yet/anymore.

So, we need to think/discuss which networks we want to include here. We also don't want to take up too much real estate in that sidebar

Thanks for the context, what I got was that publicize/social are handling automatic sharing and these buttons are meant for manually sharing for networks that publicize/social don't support in one way or another. Is my understanding correct?

In that case, I agree that this PR doesn't fit the goal of these buttons and that if we wanted to add more buttons in the post-publish panel it will need to be via another approach. Do you have any recommendations?

@manzoorwanijk
Copy link
Member

what I got was that publicize/social are handling automatic sharing and these buttons are meant for manually sharing for networks that publicize/social don't support in one way or another. Is my understanding correct?

Correct.

In that case, I agree that this PR doesn't fit the goal of these buttons and that if we wanted to add more buttons in the post-publish panel it will need to be via another approach. Do you have any recommendations?

I am not really sure yet, but we at (@Automattic/jetpack-reach) will discuss it and get back to you.

@spsiddarthan
Copy link
Contributor

Thanks for the ping! Discussed with @manzoorwanijk here - p1727414149736989-slack-C02JJ910CNL.

Our recommendation is to only have networks that we don't support for auto-sharing in the manual sharing list. But, let us know if you had other ideas/thoughts around it.

@taipeicoder
Copy link
Contributor

Thank you both for your inputs. Given that this change doesn't align with the feature's goals, I'll close this PR and discuss with the team regarding next actions 🙂

@taipeicoder taipeicoder deleted the update/remove-post-published-modal branch September 27, 2024 06:49
@github-actions github-actions bot removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review labels Sep 27, 2024
@simison
Copy link
Member

simison commented Nov 26, 2024

@taipeicoder wasn't the Pinterest getting good number of clicks in the modal, and it's not in Publicize's automatically shared networks?

@taipeicoder
Copy link
Contributor

@simison the numbers roughly were:

  • Facebook: ~2.4k per week.
  • LinkedIn: ~850 per week.
  • Tumblr: ~425 per week.
  • Pinterest: ~700 per week.

Not sure how the numbers match performance for auto-sharing, but in the modal it was close to LinkedIn. cc: @manzoorwanijk

@manzoorwanijk
Copy link
Member

CC: @Automattic/jetpack-reach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants