-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more sharing networks #39353
Add more sharing networks #39353
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
3dd43eb
to
02c485b
Compare
d57e938
to
96237e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That manual sharing is to provide an alternative for the networks that we don't support in publicize/social yet/anymore.
So, we need to think/discuss which networks we want to include here. We also don't want to take up too much real estate in that sidebar
Thanks for the context, what I got was that publicize/social are handling automatic sharing and these buttons are meant for manually sharing for networks that publicize/social don't support in one way or another. Is my understanding correct? In that case, I agree that this PR doesn't fit the goal of these buttons and that if we wanted to add more buttons in the post-publish panel it will need to be via another approach. Do you have any recommendations? |
Correct.
I am not really sure yet, but we at (@Automattic/jetpack-reach) will discuss it and get back to you. |
Thanks for the ping! Discussed with @manzoorwanijk here - p1727414149736989-slack-C02JJ910CNL. Our recommendation is to only have networks that we don't support for auto-sharing in the manual sharing list. But, let us know if you had other ideas/thoughts around it. |
Thank you both for your inputs. Given that this change doesn't align with the feature's goals, I'll close this PR and discuss with the team regarding next actions 🙂 |
@taipeicoder wasn't the Pinterest getting good number of clicks in the modal, and it's not in Publicize's automatically shared networks? |
@simison the numbers roughly were:
Not sure how the numbers match performance for auto-sharing, but in the modal it was close to LinkedIn. cc: @manzoorwanijk |
CC: @Automattic/jetpack-reach |
Related to https://github.com/Automattic/dotcom-forge/issues/9178
Proposed changes:
This PR adds the following sharing networks:
The reason these networks are added is to match the ones from the now-deprecated Sharing modal:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: