-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Checksums: Ensure is plugin active exists #39369
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It would be nice to keep track of a few cases that fataled before and see if they still have this behaviour for eg another core method. In that case, more inveestigation will be needed to figure out exactly what causes this behaviour.
* Ensure is_plugin_active exists
After #39118 , there seem to be some blogs that are fataling with
Call to undefined function Automattic\Jetpack\Sync\Modules\is_plugin_active()
. This ensures the function exists.Related logs 829c5c0c8d71089be4f19f21a2f93444-logstash
Proposed changes:
Prior art with a similar check for
get_plugins
https://github.com/Automattic/jetpack/blob/update/sync-ensure-is-plugin-active-exists/projects/packages/sync/src/modules/class-plugins.php#L367Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
I have not been able to reproduce in my local, code review should be sufficient.