Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: remove filter calls that are no longer needed (imploding CSS) #39517

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Sep 24, 2024

As we deprecate the jetpack.css concat (#39486), the default behavior is now "false" so both these filters are no longer needed. Removing them now before marking the filter as deprecated.

Proposed changes:

  • Remove calls to a filter to change it to the now-default value.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • On WordPress.com, setup a new WoA site with Coming Soon enabled.
  • Activate as much of Jetpack as you want, at least three of the imploded modules ('carousel', 'contact-form', 'infinite-scroll', 'likes', 'related-posts', 'sharedaddy', 'shortcodes', 'subscriptions', 'tiled-gallery', 'widgets')
  • Visit the front page with the Coming Soon landing page.
  • Confirm, without and without patch, jetpack.css is not enqueued on the page.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/imploding-css-filter-uses branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin remove/imploding-css-filter-uses
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@kraftbj kraftbj self-assigned this Sep 24, 2024
@kraftbj kraftbj marked this pull request as ready for review September 25, 2024 16:52
@kraftbj kraftbj added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. and removed [Status] In Progress labels Sep 25, 2024
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Sep 25, 2024
@kraftbj kraftbj merged commit 536e170 into trunk Sep 25, 2024
59 of 60 checks passed
@kraftbj kraftbj deleted the remove/imploding-css-filter-uses branch September 25, 2024 17:44
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 25, 2024
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Performance [mu wpcom Feature] Coming Soon [Package] Jetpack mu wpcom WordPress.com Features [Plugin] Wpcomsh Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants