WAF: Ensure mode is set during activation

[nateweller]

Proposed changes:

• Moves the functionality that ensures certain options exist from the on_waf_activation method (which runs on module activation) into the generic Waf_Runner::activate method (which runs on module activation, plus firewall settings updates).
• Fixes the case where a site has no "mode" option set, preventing the firewall from falling back into "silent" mode.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• Test the basic WAF functionality.
• With the firewall active, delete the jetpack_waf_mode option from your site.
• Change one of the firewall settings.
• Verify the jetpack_waf_mode option has been reset to "normal".

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/waf/ensure-mode-option-set branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/waf/ensure-mode-option-set
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[dkmyta]

Waf_Runner::activate looks as though it only runs on plugin (or more specifically WAF module, as you've noted) activation - if I delete the option it doesn't appear to get re-set by updating settings.

UPDATE: Oddly enough, I see now that this also is supposed to run on Waf_Rules_Manager::reactivate_on_rules_option_change. With the option set, it does, once deleted, it doesn't 🤔

ANOTHER UPDATE: Ah, Waf_Runner::initialize runs the above and returns early if ! self::is_allowed_mode( JETPACK_WAF_MODE ), which is the case here when the option doesn't exist.

[dkmyta]

Works as described in standard and standalone mode.

One thing I wanted to make note of to ensure it is the expected behaviour, if I delete WAF mode option but don’t reload the UI and update settings the WAF no longer functions to block test requests. It is also does not reset by simply reloading the Firewall UI but rather only on successful WAF settings updates.

[nateweller]

Thanks for the review @dkmyta 😄

One thing I wanted to make note of to ensure it is the expected behaviour, if I delete WAF mode option but don’t reload the UI and update settings the WAF no longer functions to block test requests. It is also does not reset by simply reloading the Firewall UI but rather only on successful WAF settings updates.

This is correct, the change here ultimately just moves the setting of the default mode value from the "on waf module activation" event to the more generic "on waf activation".