Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JITM: Remove JITM from Jetpack Stats dashboard (Preparation to use embedded JITM) #39714

Merged
merged 14 commits into from
Oct 15, 2024
Merged

JITM: Remove JITM from Jetpack Stats dashboard (Preparation to use embedded JITM) #39714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
91c8a4f
expose functiont to render JITM and jitm env for stats
kangzj Oct 10, 2024
e6b1f5e
changelog
kangzj Oct 10, 2024
0f3701b
fix typo
kangzj Oct 10, 2024
f0615fd
rever formatting
kangzj Oct 10, 2024
a666c95
pass jitm pass to stats admin
kangzj Oct 10, 2024
6df0610
ver and minify
kangzj Oct 10, 2024
4933214
ver and minify
kangzj Oct 10, 2024
31b6f7a
ensure it has an option to return early
kangzj Oct 10, 2024
cc4f03e
revert unnecessary chagnes
kangzj Oct 10, 2024
2e5446a
use cache buster as jitm version
kangzj Oct 11, 2024
cce0a44
add comments
kangzj Oct 11, 2024
d0201d8
revert changes
kangzj Oct 14, 2024
1c3774b
revert changes
kangzj Oct 14, 2024
411410f
Delete projects/packages/jitm/changelog/update-integration-jitm-in-stats
kangzj Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/stats-admin/changelog/update-integration-jitm-in-stats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

JITM: expose function to render message
13 changes: 13 additions & 0 deletions projects/packages/stats-admin/src/class-main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,19 @@ public static function init() {
*/
private function __construct() {
add_action( 'rest_api_init', array( new REST_Controller(), 'register_rest_routes' ) );
// Disable JITM assets on the Stats page.
// JITM is handled separately by Stats: https://github.com/Automattic/wp-calypso/pull/95273.
add_filter(
'jetpack_display_jitms_on_screen',
function ( $show, $screen_id ) {
if ( 'jetpack_page_stats' === $screen_id ) {
return false;
}
return $show;
},
10,
2
);
}

/**
Expand Down
Loading