Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fuzzy hash sample for the Scan Helper with one of a bigger size. #39750

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

ArSn
Copy link
Member

@ArSn ArSn commented Oct 11, 2024

Proposed changes:

  • Since smaller files are not checked against fuzzy hashes anymore, we needed a bigger sample for our test cases.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

1437-gh-Automattic/jetpack-scan-team

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

As we pivoted to a plan where we add a fuzzy hash for our pseudo test file, there is nothing to test right now apart from that the file is actually changed with the new content.

@github-actions github-actions bot added the [Plugin] Debug Helper Debug Tools plugin label Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Debug Helper plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 11, 2024
@ArSn ArSn added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 11, 2024
@ArSn ArSn requested a review from a team October 16, 2024 13:30
Copy link
Contributor

@bhoop bhoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good to go when we get that file added to the threat library.

@ArSn ArSn merged commit 74210e4 into trunk Oct 28, 2024
54 checks passed
@ArSn ArSn deleted the update-scan-helper-fuzzy-hash-sample branch October 28, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Debug Helper Debug Tools plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants