Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Animate Illustration #39825

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Oct 18, 2024

Proposed changes:

  • Adds an animation effect to the "scan in progress" placeholder image for users without reduced-motion enabled.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Review the Storybook entry: cd projects/js-packages/storybook && npm run storybook:dev
  • Review the animated image in Protect by starting a scan.

Screenshots

animation

@nateweller nateweller self-assigned this Oct 18, 2024
@nateweller nateweller requested a review from a team October 18, 2024 20:55
@nateweller nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Oct 18, 2024
@github-actions github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label Oct 18, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice addition!

We still face some issues with the padding of the ScanningAdminSectionHero and the size of the illustration when compared to the designs. Technically the padding of the Container is correct at 56px but because the InProgressAnimation SVG includes some internal padding of its own the spacing gets thrown off a little.

Images for reference:
Screen Shot on 2024-10-18 at 14-32-25

Screen Shot on 2024-10-18 at 14-34-08

@nateweller nateweller force-pushed the add/protect-in-progress-animation branch from 7838bf4 to 7219377 Compare October 26, 2024 00:20
@nateweller
Copy link
Contributor Author

nateweller commented Oct 26, 2024

@dkmyta I've updated the PR to apply a vertical padding of 32px to the header, and ensure the width of the graphic matches the 270px from the "Protect Meets Core" i1 designs (since the SVG has padding to accommodate the box shadows, the image width is set to 330px).

Screenshot 2024-10-25 at 6 20 15 PM

@nateweller nateweller requested a review from dkmyta October 26, 2024 00:22
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@nateweller nateweller merged commit eb8fe65 into trunk Oct 29, 2024
54 checks passed
@nateweller nateweller deleted the add/protect-in-progress-animation branch October 29, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants