Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost: Implement partial cloud CSS regeneration #39833

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Boost: Implement partial cloud CSS regeneration #39833

merged 7 commits into from
Oct 21, 2024

Conversation

haqadn
Copy link
Contributor

@haqadn haqadn commented Oct 20, 2024

Proposed changes:

  • Introduce a new filter jetpack_boost_critical_css_providers to filter the providers list
  • Remove the core_front_page provider when foundation pages is initiated
  • Add $context_posts support for WP_Core_Providers. $context_posts is an array that you can provide to a source provider. The provider list will then only include provider keys that can be impacted by the posts in the array.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

None

Testing instructions:

  • Regenerate cloud CSS
    • It shouldn't contain the provider for core_front_page.
  • Update a post
    • It should only regenerate the URLs of the site that are likely to include that post. E.g.:
      • Updating a post will update the blog page, singular_post page, category, tag archive pages
      • Updating a page will only update the singular_page page.

@haqadn haqadn requested a review from a team October 20, 2024 15:59
@haqadn haqadn self-assigned this Oct 20, 2024
@github-actions github-actions bot added [Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance. labels Oct 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/boost

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 20, 2024
@dilirity dilirity removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 21, 2024
dilirity
dilirity approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@haqadn haqadn merged commit 99cd265 into add/foundation-pages Oct 21, 2024
55 of 56 checks passed
@haqadn haqadn deleted the fp/partial-ccss-regen branch October 21, 2024 09:02
dilirity added a commit that referenced this pull request Nov 1, 2024
@dilirity @haqadn
Boost: Add cornerstone pages support (#39863)
2ed7596 
* Add a dummy foundation pages class

* changelog

* Boost: Implement partial cloud CSS regeneration (#39833)

* Improve the jetpack_boost_critical_css_urls filter

* Add a filter for the source providers

* Remove front_page as provider when foundation page is setup

* Add context support for core providers

* Implement partial regeneration

* Regenerate blog page if blog page itself is updated

* Cast core page ids to int

* Boost: Add foundation pages UI (#39832)

* Get foundation pages from datasync

* Feature flag the foundation pages UI

* Add feature flags to foundation pages class

* Boost: Add foundation provider (#39842)

Co-authored-by: Peter Petrov <[email protected]>

* Measure the first foundation page for speed score

* Add note about blog url always included in foundation pages

* Fix syntax

* Update foundation pages description text

* Boost: Add "Foundation Page" state in WP's page listing scree (#39878)

* Add indication if a page is a foundation page in WPs page listing

* add changelog

* Update page speed tooltip text

* Boost: Add notice when updating a page from the foundation pages list (#39876)

* Update foundation pages description text

* Update UI to show a critical css notice after updating a foundation page

* add changelog

* Fix static analysis

* Update notice error

* Fix missing blog page from source providers

* Boost: Prompt c.css regen when updating foundation pages list (#39881)

* Suggest regeneration when foundation pages list was updated

* add changelog

* Fix updating regenerate reason without making sure the value got updated

* Refetch regeneration reason instead of setting it after updating list

* Boost: Update foundation page list instructions (#39885)

* Boost: Add default URLs for foundation pages (#39884)

Co-authored-by: Peter Petrov <[email protected]>

* Move beta element to its own component

* Update foundation pages UI to include experiment tag

* Update foundation pages description to include upgrade link

* Replace foundation with cornerstone

* Remove feature flag for cornerstone pages

* Fix cornerstone page URLs not starting with a slash

* Fix calling undefined method

* Fix cornerstone pages UI not showing

* Change wording

* Update cornerstone description

---------

Co-authored-by: Adnan Haque <[email protected]>
Co-authored-by: Adnan Haque <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilirity dilirity dilirity approved these changes

Assignees

@haqadn haqadn

Labels
[Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haqadn @dilirity