-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Add cornerstone pages support #39863
Conversation
* Improve the jetpack_boost_critical_css_urls filter * Add a filter for the source providers * Remove front_page as provider when foundation page is setup * Add context support for core providers * Implement partial regeneration * Regenerate blog page if blog page itself is updated * Cast core page ids to int
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Co-authored-by: Peter Petrov <[email protected]>
* Add indication if a page is a foundation page in WPs page listing * add changelog
…#39876) * Update foundation pages description text * Update UI to show a critical css notice after updating a foundation page * add changelog * Fix static analysis * Update notice error * Fix missing blog page from source providers * Boost: Prompt c.css regen when updating foundation pages list (#39881) * Suggest regeneration when foundation pages list was updated * add changelog * Fix updating regenerate reason without making sure the value got updated * Refetch regeneration reason instead of setting it after updating list
Co-authored-by: Peter Petrov <[email protected]>
3c6bffa
to
40bd243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of requests:
- Feature flag is not removed. It's still hidden in the UI if the const is not defined.
- Can the tag be called "Experimental" instead of "Experiment"? Experiment implies an isolated temporary thing, not an evolving feature that may or may not stay. GPT agrees with me.
@haqadn oops, I forgot to remove the experiment flag from my wp-config 😅 I also agree with you and chatgpt that it should be experimental. Was debating the two, but I dunno why I left it in as "Experiment". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TODO:
Proposed changes:
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
no
Testing instructions: