Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Add cornerstone pages support #39863

Merged
merged 30 commits into from
Nov 1, 2024
Merged

Boost: Add cornerstone pages support #39863

merged 30 commits into from
Nov 1, 2024

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Oct 22, 2024

TODO:

Proposed changes:

  • Add cornerstone pages feature.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Setup Boost;
  • Test the cornerstone pages UI to make sure it works as expected.

haqadn and others added 7 commits October 20, 2024 16:55
* Improve the jetpack_boost_critical_css_urls filter

* Add a filter for the source providers

* Remove front_page as provider when foundation page is setup

* Add context support for core providers

* Implement partial regeneration

* Regenerate blog page if blog page itself is updated

* Cast core page ids to int
@github-actions github-actions bot added [Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels Oct 22, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dilirity dilirity changed the title Boost: Add foundation pages Boost: Add foundation pages support Oct 22, 2024
dilirity and others added 6 commits October 24, 2024 01:05
…#39876)

* Update foundation pages description text

* Update UI to show a critical css notice after updating a foundation page

* add changelog

* Fix static analysis

* Update notice error

* Fix missing blog page from source providers

* Boost: Prompt c.css regen when updating foundation pages list (#39881)

* Suggest regeneration when foundation pages list was updated

* add changelog

* Fix updating regenerate reason without making sure the value got updated

* Refetch regeneration reason instead of setting it after updating list
@dilirity dilirity changed the title Boost: Add foundation pages support Boost: Add cornerstone pages support Oct 30, 2024
@dilirity dilirity force-pushed the add/foundation-pages branch from 3c6bffa to 40bd243 Compare October 30, 2024 15:31
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of requests:

  • Feature flag is not removed. It's still hidden in the UI if the const is not defined.
  • Can the tag be called "Experimental" instead of "Experiment"? Experiment implies an isolated temporary thing, not an evolving feature that may or may not stay. GPT agrees with me.

@dilirity
Copy link
Member Author

@haqadn oops, I forgot to remove the experiment flag from my wp-config 😅

I also agree with you and chatgpt that it should be experimental. Was debating the two, but I dunno why I left it in as "Experiment".

Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dilirity dilirity merged commit 2ed7596 into trunk Nov 1, 2024
61 checks passed
@dilirity dilirity deleted the add/foundation-pages branch November 1, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Boost Feature] Cloud CSS [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants