Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreatsDataViews: Update isPrimary actions #39871

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Oct 22, 2024

Description #
Moves access to actions toggles inline and hides the collapsible actions list

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch
  • Load storybook with cd projects/js-packages/storybook && npm run storybook:dev
  • View the Threats Data View component
  • Ensure the content of the actions section is positioned and styled according to designs in both Table and List views
  • Review the code and ensure the implementation is correct

Screenshots

Table View:
Screen Shot on 2024-10-22 at 13-57-16

List View:
Screen Shot 2024-10-22 at 14 32 29

nateweller and others added 4 commits October 21, 2024 14:06
Add support for list view in threats data table

Minor adjustments

Add badge component and integrate with threats data view

Update stories and align auto-fix column
@dkmyta dkmyta marked this pull request as ready for review October 22, 2024 21:03
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/components/threats-data-view-actions branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/components/threats-data-view-actions
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/components/threats-data-view-actions
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@dkmyta dkmyta changed the base branch from trunk to add/components/threats-data-view October 22, 2024 21:04
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Comment on lines +40 to +43
&:focus,
&:focus-visible {
box-shadow: none;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we compensate for this with other focus styles?

Copy link
Contributor Author

@dkmyta dkmyta Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not - I wasn't quite sure to what extent we should compensate for all these things directly within the component or whether various parts should be handled in the implementation.

I removed the built in button element pseudo-class styles here and set the internal span element, text styles and a hover effect to match the colours in the designs, but there are other pieces in the component where we default to wp-admin style settings. Should we account for all of this here, or should we allow for the default and update everything where it's in use?

Add support for list view in threats data table

Minor adjustments

Add badge component and integrate with threats data view

Update stories and align auto-fix column

Update ThreatDataView list view fixer status (#39854)
@nateweller nateweller force-pushed the add/components/threats-data-view branch from 7da9b3e to e63ea79 Compare October 23, 2024 04:00
@nateweller nateweller force-pushed the add/components/threats-data-view branch 9 times, most recently from d3a5a21 to 311ba67 Compare October 25, 2024 00:57
@nateweller nateweller force-pushed the add/components/threats-data-view branch 19 times, most recently from 0a1b0bd to 58f6f3e Compare October 29, 2024 20:24
@dkmyta dkmyta changed the title Update ThreatsDataView isPrimary actions ThreatsDataViews: Update isPrimary actions Nov 4, 2024
@github-actions github-actions bot added [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests labels Nov 4, 2024
@nateweller nateweller force-pushed the add/components/threats-data-view branch from 58f6f3e to dd1f233 Compare November 5, 2024 18:46
@dkmyta
Copy link
Contributor Author

dkmyta commented Nov 5, 2024

Closing in favour of adding the primary fixer actions to a dedicated column and keeping secondary action in the collapsible list as proposed in #39754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [JS Package] Scan [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants