-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThreatsDataViews: Update isPrimary actions #39871
ThreatsDataViews: Update isPrimary actions #39871
Conversation
Add support for list view in threats data table Minor adjustments Add badge component and integrate with threats data view Update stories and align auto-fix column
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
projects/js-packages/components/components/threats-data-view/index.tsx
Outdated
Show resolved
Hide resolved
…s/threats-data-view-actions
projects/js-packages/components/components/threats-data-view/index.tsx
Outdated
Show resolved
Hide resolved
&:focus, | ||
&:focus-visible { | ||
box-shadow: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we compensate for this with other focus styles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not - I wasn't quite sure to what extent we should compensate for all these things directly within the component or whether various parts should be handled in the implementation.
I removed the built in button element pseudo-class styles here and set the internal span element, text styles and a hover effect to match the colours in the designs, but there are other pieces in the component where we default to wp-admin style settings. Should we account for all of this here, or should we allow for the default and update everything where it's in use?
Add support for list view in threats data table Minor adjustments Add badge component and integrate with threats data view Update stories and align auto-fix column Update ThreatDataView list view fixer status (#39854)
7da9b3e
to
e63ea79
Compare
…s/threats-data-view-actions
d3a5a21
to
311ba67
Compare
0a1b0bd
to
58f6f3e
Compare
58f6f3e
to
dd1f233
Compare
Closing in favour of adding the primary fixer actions to a dedicated column and keeping secondary action in the collapsible list as proposed in #39754. |
Description #
Moves access to actions toggles inline and hides the collapsible actions list
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
cd projects/js-packages/storybook && npm run storybook:dev
Screenshots
Table View:
List View: