Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Fix Bluesky custom domain handle not being accepted #39872

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Social: Fix Bluesky custom domain handle not being accepted #39872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...kages/publicize-components/changelog/fix-social-bluesky-custom-domain-handles-not-working
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Social: Fixed Bluesky custom domain handle not being accepted
8 changes: 4 additions & 4 deletions projects/js-packages/publicize-components/src/components/services/use-request-access.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const isValidMastodonUsername = ( username: string ) =>

/**
* Example valid handles:
* - domain.tld
* - username.bsky.social
* - user-name.bsky.social
* - my_domain.com.bsky.social
* - my-domain.com.my-own-server.com
* - my-domain.com
*
* @param {string} handle - Handle to validate
*
Expand All @@ -23,8 +23,8 @@ const isValidMastodonUsername = ( username: string ) =>
function isValidBlueskyHandle( handle: string ) {
const parts = handle.split( '.' ).filter( Boolean );

// A valid handle should have at least 3 parts - username, domain, and tld
if ( parts.length < 3 ) {
// A valid handle should have at least 2 parts - domain, and tld
if ( parts.length < 2 ) {
return false;
}

Expand Down
Loading