Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Migrate Social Image Generator settings initial state #39904

Merged
merged 13 commits into from
Nov 1, 2024

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Oct 25, 2024

Proposed changes:

  • Migrate Social Image Generator settings initial state

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to Social admin page
  • Toggle SIG ON/OFF
  • Confirm that the request in the Network tab is a success
  • Reload the page
  • Confirm that the change is persisted
  • Confirm the same on Jetpack settings page
  • Create a new post
  • Open Jetpack/Social sidebar
  • Confirm that the settings updated above are reflected in the editor
  • Do a sanity check on WPCOM sites editor

@manzoorwanijk manzoorwanijk mentioned this pull request Oct 25, 2024
3 tasks
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/migrate-sid-settings-to-new-store branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/migrate-sid-settings-to-new-store
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/migrate-sid-settings-to-new-store
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu RNA labels Oct 25, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for November 5, 2024 (scheduled code freeze on November 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@manzoorwanijk manzoorwanijk self-assigned this Oct 25, 2024
@manzoorwanijk manzoorwanijk requested a review from a team October 25, 2024 12:39
@manzoorwanijk manzoorwanijk marked this pull request as ready for review October 25, 2024 12:39
@manzoorwanijk manzoorwanijk marked this pull request as draft October 25, 2024 12:52
@manzoorwanijk manzoorwanijk force-pushed the update/migrate-sid-settings-to-new-store branch 2 times, most recently from fb77edd to ca69d22 Compare October 25, 2024 16:14
@manzoorwanijk manzoorwanijk marked this pull request as ready for review October 25, 2024 16:14
@manzoorwanijk manzoorwanijk force-pushed the update/migrate-sid-settings-to-new-store branch from ca69d22 to 1339b0d Compare October 31, 2024 10:49
@manzoorwanijk manzoorwanijk changed the base branch from add/wp-data-sync-package to trunk October 31, 2024 10:50
@manzoorwanijk manzoorwanijk changed the title Social: Migrate Social Image Generator settings to new store Social: Migrate Social Image Generator settings initial state Oct 31, 2024
Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well. I'm glad we can get rid of all the complex refresh logic.

I did have a situation where the toggle got out of sync with the setting state, but I can't replicate it now, and my guess is that it was something with my development environment and JS code getting out of sync with the PHP.

@manzoorwanijk manzoorwanijk merged commit 13222c6 into trunk Nov 1, 2024
74 checks passed
@manzoorwanijk manzoorwanijk deleted the update/migrate-sid-settings-to-new-store branch November 1, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants