-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DIFM-specific functionality for WoA sites #39915
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Hi, can you add any context for this PR? Thanks |
Hi @oskosk, this is a very early draft, and depending on feedback, we may or may not proceed with it. As the PR progresses, I'll keep adding details and testing instructions. For now, I have added the GH issue link to the PR. Hope that it's okay! |
e9acd0b
to
a44a1d8
Compare
a44a1d8
to
2046862
Compare
Fixes https://github.com/Automattic/martech/issues/3505
Proposed changes:
Fixes https://github.com/Automattic/martech/issues/3505
This PR contains the following changes:
When the
difm-lite-in-progress
sticker is active for a WoA site, and the user is NOT proxied:Always show the Coming Soon page.
Hide the admin bar.
Hide all menu items in wp-admin except for Hosting->{Email, Domain, Purchases}.
Replace wp-admin page content with this notice:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Setup
define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
to your wp-config.php file. (Usually in/htdocs/wp-config.php
)difm-lite-in-progress
sticker./wp-admin/admin.php?page=jetpack-beta&plugin=jetpack-mu-wpcom-plugin
.add/wpcom-difm-functions
. (This branch)difm-lite-in-progress
sticker.Testing
Proxy Off
Visit the website URL. Confirm that the Coming Soon page is shown.
Confirm that the admin bar is not shown. The following is a screenshot of the admin bar.
Go to /wp-admin
Confirm that only the Hosting menu is present in the side bar and contains the following items:
Confirm that the sub menu items point to the correct URLs.
Confirm that the content area is replaced by this:
Click on the button in the above notice.
Confirm it takes you to the content submission form and submit content.
Go to
/wp-admin
.Confirm that the content area is replaced by by this:
Proxy On