-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Add optional hover support to the IconTooltip component #39916
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
81d25c6
to
18277d1
Compare
18277d1
to
0802197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well 👍
Originally removed in #26457, this PR restores the ability for
IconTooltip
components to show the tooltip on hover (enabled by a newhoverShow
prop).This change came from @dkmyta while working on #39754. We're hoping that by adding hover support to this component, we can use it in Jetpack Protect as well as in other scan components.
Proposed changes:
hoverShow
prop to theIconTooltip
component.onMouseEnter
andonMouseLeave
event listeners, which show and hide the tooltip whenhoverShow
is enabled.timeout
to provide a short delay before hiding the tooltip on mouse leave.Other information:
Jetpack product discussion
https://github.com/Automattic/jetpack-scan-team/issues/1475
Does this pull request change what data or activity we track or use?
No
Testing instructions:
IconTooltip
component's storybooks:cd projects/js-packages/storybook && npm run storybook:dev
Screenshots: