Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wc-calypso-bridge to v2.8.1 #39950

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update wc-calypso-bridge to v2.8.1 #39950

merged 2 commits into from
Oct 30, 2024

Conversation

Ferdev
Copy link
Contributor

@Ferdev Ferdev commented Oct 29, 2024

Proposed changes:

This PR bumps the version of wc-calypso-bridge to 2.8.1, which includes the following changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

The changes related to the wc-calypso-bridge were already tested in the linked PRs. Testing instructions can be found on the linked PRs above.

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 29, 2024
@Ferdev Ferdev added [Action] Required Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 29, 2024
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 29, 2024
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing composer.lock update.

@Ferdev
Copy link
Contributor Author

Ferdev commented Oct 30, 2024

Sorry about that, @moon0326! Totally missed that part, this was my first PR in this repo 🤦‍♂️ Should be fine now 👍

Thanks!

@Ferdev Ferdev requested a review from moon0326 October 30, 2024 10:19
@Ferdev Ferdev removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 30, 2024
@moon0326
Copy link
Contributor

moon0326 commented Oct 30, 2024

Sorry about that, @moon0326! Totally missed that part, this was my first PR in this repo 🤦‍♂️ Should be fine now 👍

Thanks!

No worries 😄 I forget about it from time to time too. LGTM! 🚀

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚀

@Ferdev Ferdev merged commit d1ebbe9 into trunk Oct 30, 2024
54 checks passed
@Ferdev Ferdev deleted the update/bridge branch October 30, 2024 17:15
@Ferdev
Copy link
Contributor Author

Ferdev commented Oct 30, 2024

awesome, thanks @moon0326! Is merging the PR enough to get this deployed, or is there anything else I should to for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants