Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreatsDataViews: Update Extension filter #40043

Closed

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Nov 4, 2024

Description

Replaces the Extension filter with a more specific set of options - Plugin and Theme.

Proposed changes:

  • Filter out plugins and themes in the extensions block of the primary threats data computation.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch
  • Load storybook with cd projects/js-packages/storybook && npm run storybook:dev
  • View the Threats Data View component
  • Ensure the list filter includes a Plugin and Theme option (will need to modify the story data in order to render the Theme filter) when a threats exists for either and that Extension is no longer an option
  • Verify that applying the filter works
  • Ensure no regressions are introduced

Screenshots

Screen Shot 2024-11-04 at 12 57 25

@dkmyta dkmyta changed the base branch from trunk to add/components/threats-data-view November 4, 2024 20:55
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/components/threats-data-views-extension-filter branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/components/threats-data-views-extension-filter
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/components/threats-data-views-extension-filter
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@dkmyta dkmyta self-assigned this Nov 4, 2024
@dkmyta dkmyta changed the title Update ThreatsDataViews Extension filter ThreatsDataViews: Update Extension filter Nov 4, 2024
@nateweller nateweller force-pushed the add/components/threats-data-view branch 3 times, most recently from 25254f3 to 79804d5 Compare November 5, 2024 21:58
Base automatically changed from add/components/threats-data-view to trunk November 6, 2024 16:33
@dkmyta
Copy link
Contributor Author

dkmyta commented Nov 6, 2024

Applied in #39754

@dkmyta dkmyta closed this Nov 6, 2024
@dkmyta dkmyta deleted the update/components/threats-data-views-extension-filter branch November 6, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant