Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan JS Package: Remove Build #40262

Closed
wants to merge 2 commits into from
Closed

Scan JS Package: Remove Build #40262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8870b01
Scan JS Package: Remove references to build step
nateweller Nov 19, 2024
8b8d666
Restore production build script
nateweller Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/js-packages/scan/changelog/remove-build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fixed configuration issues in the package.json file.
8 changes: 2 additions & 6 deletions projects/js-packages/scan/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,10 @@
"build-production": [
"NODE_ENV=production BABEL_ENV=production pnpm run build"
],
"watch": [
"Composer\\Config::disableProcessTimeout",
"pnpm run watch"
],
"test-coverage": "pnpm run test-coverage",
"test-js": [
"pnpm run test"
]
],
"test-coverage": "pnpm run test-coverage"
},
"repositories": [
{
Expand Down
20 changes: 8 additions & 12 deletions projects/js-packages/scan/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,13 @@
},
"license": "GPL-2.0-or-later",
"author": "Automattic",
"type": "module",
"scripts": {
"build": "pnpm run clean && pnpm run compile-ts",
"clean": "rm -rf build/",
"build": "pnpm run compile-ts",
"compile-ts": "tsc --pretty",
"test": "jest",
"test-coverage": "pnpm run test --coverage"
},
"type": "module",
"devDependencies": {
"@automattic/jetpack-webpack-config": "workspace:*",
"@babel/core": "7.26.0",
Expand All @@ -41,15 +40,6 @@
"storybook": "8.3.5",
"typescript": "5.0.4"
},
"exports": {
".": {
"jetpack:src": "./src/index.ts",
"types": "./build/index.d.ts",
"default": "./build/index.js"
}
},
"main": "./build/index.js",
"types": "./build/index.d.ts",
"dependencies": {
"@automattic/jetpack-api": "workspace:*",
"@automattic/jetpack-base-styles": "workspace:*",
Expand All @@ -65,5 +55,11 @@
"@wordpress/i18n": "5.11.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"exports": {
".": {
"types": "./src/index.d.ts",
"default": "./src/index.ts"
}
}
}
Loading