-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WordAds]: Ad formats migration to WATL #40308
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
5f580cf
to
e679001
Compare
d766e7d
to
adeab2a
Compare
a9933e9
to
b418402
Compare
b418402
to
5b622dc
Compare
* Update Smart class to handle new formats * Fix sas_fallback variable and add sidebar tag * Add sidebar on Smart formats to support the legacy sidebar widget * Add resource hints * Reorder methods * Fix enabled check for top format * Undo the support for sidebar format and minor fixes
* Render legacy sidebar widget with the WATL * Replace null with empty as the right hand side * Use the new Smarts for the sidebar widget * Remove redundant check * Move mapping array to constant * Update changelog
f9711df
to
9585244
Compare
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
<site-url>?wordads-logging=true&gutenberg_rectangle=true&gutenberg_skyscraper=true&gutenberg_mobile_leaderboard=true
<site-url>?wordads-logging=true&sidebar_widget_mediumrectangle=true&sidebar_widget_leaderboard=true&sidebar_widget_wideskyscraper=true
<site-url>?wordads-logging=true&sidebar=true
<site-url>?wordads-logging=true&sidebar_sticky_right
<site-url>?wordads-logging=true&top=true
<site-url>?wordads-logging=true&belowpost=true
<site-url>?wordads-logging=true&shortcode=true