Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WordAds]: Ad formats migration to WATL #40308

Open
wants to merge 20 commits into
base: trunk
Choose a base branch
from

Conversation

Alameen688
Copy link
Contributor

@Alameen688 Alameen688 commented Nov 22, 2024

Proposed changes:

  • This PR migrates supported ad formats due to migration away from IPONWEB to our Adflow + WATL (WordAds Tag Library) setup

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Visit your test site and test all migrated formats using the query string.
  • Test Gutenberg ad blocks <site-url>?wordads-logging=true&gutenberg_rectangle=true&gutenberg_skyscraper=true&gutenberg_mobile_leaderboard=true
  • Test Legacy sidebar widget <site-url>?wordads-logging=true&sidebar_widget_mediumrectangle=true&sidebar_widget_leaderboard=true&sidebar_widget_wideskyscraper=true
  • Test sidebar format <site-url>?wordads-logging=true&sidebar=true
  • Test sidebar sticky right format <site-url>?wordads-logging=true&sidebar_sticky_right
  • Test top format <site-url>?wordads-logging=true&top=true
  • Test belowpost <site-url>?wordads-logging=true&belowpost=true
  • Test shortcode <site-url>?wordads-logging=true&shortcode=true

@Alameen688 Alameen688 changed the title [WordAds] WIP: Ad formats migration to WATL [WordAds] Ad formats migration to WATL Nov 22, 2024
@Alameen688 Alameen688 changed the title [WordAds] Ad formats migration to WATL [WordAds]: Ad formats migration to WATL Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/ipw-to-watl-adflow-migration branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/ipw-to-watl-adflow-migration
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Ad [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@Alameen688 Alameen688 force-pushed the update/ipw-to-watl-adflow-migration branch from 5f580cf to e679001 Compare November 26, 2024 12:05
@Alameen688 Alameen688 force-pushed the update/ipw-to-watl-adflow-migration branch 2 times, most recently from d766e7d to adeab2a Compare December 3, 2024 13:54
@Alameen688 Alameen688 force-pushed the update/ipw-to-watl-adflow-migration branch 2 times, most recently from a9933e9 to b418402 Compare December 12, 2024 18:22
@Alameen688 Alameen688 force-pushed the update/ipw-to-watl-adflow-migration branch from b418402 to 5b622dc Compare December 18, 2024 12:45
Alameen688 and others added 6 commits December 23, 2024 14:22
* Update Smart class to handle new formats

* Fix sas_fallback variable and add sidebar tag

* Add sidebar on Smart formats to support the legacy sidebar widget

* Add resource hints

* Reorder methods

* Fix enabled check for top format

* Undo the support for sidebar format and minor fixes
* Render legacy sidebar widget with the WATL

* Replace null with empty as the right hand side

* Use the new Smarts for the sidebar widget

* Remove redundant check

* Move mapping array to constant

* Update changelog
@Alameen688 Alameen688 force-pushed the update/ipw-to-watl-adflow-migration branch from f9711df to 9585244 Compare December 23, 2024 14:25
@Alameen688 Alameen688 marked this pull request as ready for review December 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Ad [Feature] Ad [Feature] Shortcodes / Embeds [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants