-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reliable way to detect checkout page #40523
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
@@ -198,7 +198,7 @@ function ( $payment_gateway ) { | |||
|
|||
$enabled_payment_options = array_keys( $enabled_payment_options ); | |||
|
|||
$is_in_checkout_page = $checkout_page_id === $post->ID ? 'Yes' : 'No'; | |||
$is_in_checkout_page = $checkout_page_id && is_page( $checkout_page_id ) ? 'Yes' : 'No'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WooCommerce core uses the same approach
projects/packages/woocommerce-analytics/src/class-checkout-flow.php
Outdated
Show resolved
Hide resolved
…w.php Co-authored-by: Jeremy Herve <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, thanks!
Should we update the checks here too:
jetpack/projects/packages/woocommerce-analytics/src/class-woo-analytics-trait.php
Lines 176 to 182 in 5315079
if ( $cart_page && isset( $cart_page->post_content ) ) { | |
$this->cart_content_source = $cart_page->post_content; | |
} | |
if ( $checkout_page && isset( $checkout_page->post_content ) ) { | |
$this->checkout_content_source = $checkout_page->post_content; | |
} |
We are seeing a bunch of warnings in WCCOM
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?