Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Connections API schema front end changes #40539

Open
wants to merge 18 commits into
base: social/unified-connections-management
Choose a base branch
from

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Dec 10, 2024

Related to #40677

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to connections management
  • Verify that the connection name is displayed correctly for all the connections
  • Remove the display name from your Bluesky profile and reconnect it
  • Verify that the display name for the connection is the blueksy handle
  • Add a Mastodon connection and then break the connection by removing Jetpack here.
  • Change the tab in the edior and come back or reload the page in case of settings page to have the broken connection reflected
  • In the editor, verify that the broken connection notice shows up fine.
  • Reconnect the broken Mastodon account
  • Verify that reconnection works fine (with the correct handle)
  • In editor, toggle the connections ON/OFF to confirm it works fine
  • Try to send post only to 1 network, rest toggled off to verify it works
  • If you have an unsupported network like Twitter added, verify it's marked as unsupported. I verified it for my old Twitter connection.
  • In the Jetpack sidebar, click on Preview social posts
  • Verify that the connections are displayed fine

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-schema-front-end-changes branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-schema-front-end-changes
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@manzoorwanijk manzoorwanijk added the DO NOT MERGE don't merge it! label Dec 10, 2024
@manzoorwanijk manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from d4e04c0 to f04b25c Compare December 13, 2024 08:44
@manzoorwanijk manzoorwanijk self-assigned this Dec 13, 2024
@manzoorwanijk manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from 0b628da to 8eb70f8 Compare December 19, 2024 05:46
@manzoorwanijk manzoorwanijk marked this pull request as ready for review December 19, 2024 06:20
@manzoorwanijk manzoorwanijk requested a review from a team December 19, 2024 06:20
@manzoorwanijk manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from ebf0c82 to 4a4a0e2 Compare December 19, 2024 07:33
@manzoorwanijk manzoorwanijk changed the base branch from trunk to update/unify-social-connections-schema December 19, 2024 07:33
@manzoorwanijk manzoorwanijk added DO NOT MERGE don't merge it! and removed [Status] In Progress labels Dec 19, 2024
@manzoorwanijk manzoorwanijk force-pushed the update/unify-social-connections-schema branch from 1adc9a8 to d1762a9 Compare December 19, 2024 08:29
@manzoorwanijk manzoorwanijk force-pushed the update/social-schema-front-end-changes branch from 4a4a0e2 to 0379da4 Compare December 19, 2024 08:30
Copy link
Contributor

@gmjuhasz gmjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but @pablinos should take a look as well as it's a fairly big change

@manzoorwanijk manzoorwanijk removed the DO NOT MERGE don't merge it! label Dec 20, 2024
Base automatically changed from update/unify-social-connections-schema to social/unified-connections-management December 20, 2024 09:42
@manzoorwanijk manzoorwanijk force-pushed the social/unified-connections-management branch from d6b615d to a749a20 Compare December 20, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants