Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social | Add wpcom/v3/publicize/services endpoint #40559

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Dec 11, 2024

Extracted out of #40536

Proposed changes:

  • Add wpcom/v3/publicize/services endpoint that can be used in every scenario the publicize module is used
    • WPCOM sites
    • Jetpack sites - both Jetpack and Social plugins

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply this PR to your sandbox and point public API to the sandbox
  • Goto Developer console
  • Hit WP REST API - wpcom/v3/sites/<site_id>/publicize/services
  • Confirm that the services are displayed correctly as per the schema in this PR
  • Point your Jetpack site to the sandbox
  • Goto any page which uses wp.apiFetch e.g. Block Editor
  • In console, run this
await wp.apiFetch({
    path: '/wpcom/v3/publicize/services'
});
  • Confirm that the services are displayed correctly as per the schema in this PR
Screenshot 2024-12-11 at 10 24 25 AM Screenshot 2024-12-11 at 10 24 55 AM

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/social-unified-services-endpoint branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/social-unified-services-endpoint
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 11, 2024
@manzoorwanijk manzoorwanijk self-assigned this Dec 11, 2024
@manzoorwanijk manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 11, 2024
@manzoorwanijk manzoorwanijk requested a review from a team December 11, 2024 05:20
@manzoorwanijk manzoorwanijk force-pushed the add/social-unified-services-endpoint branch from 0ea90ca to ab66811 Compare December 11, 2024 12:26
@manzoorwanijk manzoorwanijk changed the base branch from trunk to add/social-unitied-connections-endpoint December 11, 2024 12:26
@github-actions github-actions bot added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] WPCOM API [Package] Image CDN [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Debug Helper Debug Tools plugin [Plugin] Inspect [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin labels Dec 11, 2024
@manzoorwanijk manzoorwanijk force-pushed the add/social-unified-services-endpoint branch from 0b9b89f to 4eb8da1 Compare December 12, 2024 04:26
@manzoorwanijk
Copy link
Member Author

Closing in favour of #40596

@manzoorwanijk manzoorwanijk deleted the add/social-unified-services-endpoint branch December 13, 2024 06:36
@manzoorwanijk manzoorwanijk restored the add/social-unified-services-endpoint branch December 19, 2024 05:23
@manzoorwanijk manzoorwanijk reopened this Dec 19, 2024
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 19, 2024
@manzoorwanijk manzoorwanijk deleted the add/social-unified-services-endpoint branch December 19, 2024 05:25
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant