-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost: Add notices to settings page when modules/settings changed #40593
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
This reverts commit d1ca285.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good and works as expected. I have a few suggestions.
projects/plugins/boost/app/assets/src/js/features/cornerstone-pages/meta/meta.tsx
Outdated
Show resolved
Hide resolved
projects/plugins/boost/app/assets/src/js/features/cornerstone-pages/meta/meta.tsx
Outdated
Show resolved
Hide resolved
projects/plugins/boost/app/assets/src/js/features/minify-meta/minify-meta.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #36330
Proposed changes:
Demo
hDKvPhJCw2LMa7NRjtokh1OSErzTzNFU0XhLe6IA.mp4
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: