Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Add notices to settings page when modules/settings changed #40593

Merged
merged 25 commits into from
Dec 19, 2024

Conversation

donnchawp
Copy link
Contributor

@donnchawp donnchawp commented Dec 12, 2024

Fixes #36330

Proposed changes:

Demo
hDKvPhJCw2LMa7NRjtokh1OSErzTzNFU0XhLe6IA.mp4
  • Add notices when modules are toggled or sub-settings are changed;
  • Remove useEffect in minify meta;
  • Update time when notifications disappear from 5 to 2 seconds.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Load the settings page and enable/disable modules, or change settings.

@donnchawp donnchawp added [Status] In Progress [Plugin] Boost A feature to speed up the site and improve performance. labels Dec 12, 2024
@donnchawp donnchawp self-assigned this Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@donnchawp donnchawp marked this pull request as ready for review December 17, 2024 13:54
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and works as expected. I have a few suggestions.

@donnchawp donnchawp requested a review from haqadn December 19, 2024 13:44
@dilirity dilirity added this to the boost/next milestone Dec 19, 2024
Copy link
Contributor

@haqadn haqadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haqadn haqadn merged commit ec9fc87 into trunk Dec 19, 2024
62 checks passed
@haqadn haqadn deleted the update/boost/add-notices-to-settings-page branch December 19, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Boost A feature to speed up the site and improve performance. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boost: Show confirmation when enabling/disabling features
3 participants