-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Fix - Update getting raw post type count #40635
Conversation
Updating the function get_raw_post_type_breakdown for sites with high post counts as the query can cause backend issues for sites with a lot of post. If the sites total post count exceeds a million posts the query will be handled remotely and the results of a remote request used for My Jetpack
Add changelog
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Check the result of the remote request for raw post type breakdown
Always queue the remote post count query if the post count is over the local query limit.
projects/packages/my-jetpack/src/products/class-search-stats.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than @gibrown's question, the code looks good! 👍🏾
Update the query limit to 100k vs 1 million
Update the changelog for the updated query limit
Fixes # #38130
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
POST_COUNT_QUERY_LIMIT
constant in the PR to a low number for testing purposes and to trigger the remote query.raw_post_type_breakdown
is set on the remote site.Get Search
loads as expected.