Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Fix - Update getting raw post type count #40635

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

oikeme
Copy link
Contributor

@oikeme oikeme commented Dec 16, 2024

Fixes # #38130

Proposed changes:

  • For sites with a high post count (over 1 million posts) a remote request will now be used instead of the local query found in get_raw_post_type_breakdown which has been identified as potentially causing backend issues.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • This test will require a site with over a million post to test that the remote call is triggered correctly. Alternatively this can be tested by updating the POST_COUNT_QUERY_LIMIT constant in the PR to a low number for testing purposes and to trigger the remote query.
  • Visit My Jetpack and ensure that the remote call is made. You can verify this by confirming the option raw_post_type_breakdown is set on the remote site.
  • Ensure that My Jetpack loads as expected.
  • Verify the pricing page when clicking on Get Search loads as expected.

Updating the function get_raw_post_type_breakdown for sites with high post counts as the query can cause backend issues for sites with a lot of post. If the sites total post count exceeds a million posts the query will be handled remotely and the results of a remote request used for My Jetpack
@oikeme oikeme self-assigned this Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/update-raw-post-type-count branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/update-raw-post-type-count
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@oikeme oikeme added the [Type] Bug When a feature is broken and / or not performing as intended label Dec 16, 2024
Check the result of the remote request for raw post type breakdown
@oikeme oikeme changed the title Fix/update raw post type count My Jetpack: Fix - Update getting raw post type count Dec 17, 2024
Always queue the remote post count query if the post count is over the local query limit.
IanRamosC
IanRamosC previously approved these changes Dec 19, 2024
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @gibrown's question, the code looks good! 👍🏾

Update the query limit to 100k vs 1 million
Update the changelog for the updated query limit
@oikeme oikeme merged commit c023479 into trunk Dec 19, 2024
73 checks passed
@oikeme oikeme deleted the fix/update-raw-post-type-count branch December 19, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants