Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeql: Remove unneeded advanced config file #40674

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Dec 18, 2024

Proposed changes:

GitHub has a "default" config and an "advanced" config. It turns out the "advanced" config we have here doesn't do anything very advanced, we can switch to the default config.

See https://github.com/Automattic/jetpack/security/code-scanning/438

When I did that, it disabled the workflow but didn't create a PR to delete this file for us. Guess we have to do that manually.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • 🤷

GitHub has a "default" config and an "advanced" config. It turns out the
"advanced" config we have here doesn't do anything very advanced, we can
switch to the default config.

See https://github.com/Automattic/jetpack/security/code-scanning/438

When I did that, it disabled the workflow but didn't create a PR to
delete this file for us. Guess we have to do that manually.
@anomiex anomiex added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Dec 18, 2024
@anomiex anomiex requested a review from a team December 18, 2024 20:59
@anomiex anomiex self-assigned this Dec 18, 2024
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Dec 18, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first typed 🦐 but meant 🤷. 🪓!

@anomiex anomiex merged commit 74426d7 into trunk Dec 18, 2024
58 checks passed
@anomiex anomiex deleted the remove/codeql-advanced-config-file branch December 18, 2024 22:02
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants