Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Make sure source provider URLs are unique #40701

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Dec 20, 2024

Proposed changes:

  • Remove core_front_page provider and code removing it. We added this when working on Cornerstone Pages, and the logic was behind a feature flag. There's no longer a feature flag, so it's okay to remove the source provider and the code that was previously removing it.
  • Update critical css UI to consider cornerstone pages as important and show an error if one of them fails. core_front_page is no longer an important page as it no longer exists as a provider. This partially addresses Boost: Should C.CSS generation continue if an important provider fails #40391.
  • Remove WP Core Provider URLs from list, if they are present in Cornerstone Pages list;
  • Remove possible duplicate blog page, if it was in the cornerstone pages list when a static page was not set, but a blog page was set.
  • Fix bug that made "Load default pages" button clickable after loading defaults and saving. This happens when Yoast had the home page as a cornerstone page and it was also in Boost's cornerstone pages list.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Setup Boost (free);
  • You can use Boost companion, to easily check the list of source providers by opening http://jetpack-boost.test/wp-json/jetpack-boost/v1/list-source-providers
  • Add some pages, set a static page, no blog page, add cornerstone pages. In other words - play around with the cornerstone pages and see if the list of source providers behaves correctly.

We were removing this with a filter during development of Cornerstone
Pages because we had a feature flag. Since it's part of Boost now,
we don't need the provider and the filter to remove it.
@dilirity dilirity added [Status] Needs Team Review [Plugin] Boost A feature to speed up the site and improve performance. [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost labels Dec 20, 2024
@dilirity dilirity added this to the boost/next milestone Dec 20, 2024
@dilirity dilirity requested a review from a team December 20, 2024 12:34
@dilirity dilirity self-assigned this Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 20, 2024
@dilirity dilirity added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Dec 20, 2024
@haqadn haqadn removed this from the boost/next milestone Dec 20, 2024
@haqadn
Copy link
Contributor

haqadn commented Dec 20, 2024

Skipping from this beta as we still need to finish the discussion about what is an important provider for critical CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Plugin] Boost A feature to speed up the site and improve performance. [Status] Needs Team Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants