Classic Theme Helper: Require Nova Restaurant CPT from the package

[coder-karen]

Fixes https://github.com/Automattic/vulcan/issues/634
Fixes https://github.com/Automattic/vulcan/issues/635
Fixes https://github.com/Automattic/vulcan/issues/636

For deployment: If wpcomsh is deployed first (before Jetpack) on WoA then the Nova Restaurant CPT will be initialized twice, but this shouldn't be a problem for a short period of time.

Note: 169515-ghe-Automattic/wpcom needs to be deployed before this is merged.

Proposed changes:

• This PR ensures we are requiring the newly moved Nova Restaurant code from the Classic Theme Helper package, in the Jetpack, Jetpack Mu WPcom plugins and Classic Theme Helper plugin.
• This PR also adds in deprecations to related functions in the nova.phpmodule file, adding custom calling functions as well.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See issues above.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Self-hosted / WoA:
On trunk:

• Install and activate a theme that supports Restaurant Menus such as Confit.
• Add several new menu items from the new Food Menu in the admin menu.
• Add some new sections, and add menu items to specific sections (see the Menu Sections area in the menu editor). Ensure some sections are parents to other sections
• Attempt adding multiple menu items at once using the 'Add Many Items' menu option.
• Using quick edit from the main menu list for specific item, change the sections they belong to in some cases.
• Try dragging and dropping menu items to different positions and sections.
• Click save new order, everything should save correctly.

With this PR applied:

• Follow the same steps as above.
  • For WoA: Using the Jetpack Beta tester plugin, test with the branched checked out via the WordPress.com Features plugin, the Jetpack plugin, and then both.
  • Ensure when switching to the branch that items within designated menu sections on the main Menu Items page - /wp-admin/edit.php?post_type=nova_menu_item - remain unchanged.
  • Make sure there are no deprecation notices in error logs while testing.

Simple:

• Follow the same steps as above. To apply changes in this PR, follow the steps to use the commands shared in the generated comment below, for a sandboxed Simple site.
• Make sure there are no deprecation notices in error logs while testing: tail -f /tmp/php-errors

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/require-nova-restaurant-cpt-in-classic-theme-helper branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/require-nova-restaurant-cpt-in-classic-theme-helper
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/require-nova-restaurant-cpt-in-classic-theme-helper
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for January 7, 2025 (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.