Merge pull request #7711 from Automattic/release/4.24.4

Release 4.24.4

changelog.txt

@@ -1,5 +1,24 @@
 *** Changelog ***
 
+## 4.24.4 - 2024-11-12
+### Security
+- Messages and emails accessible using the search REST API
+
+### Added
+- Allow additional users to manage students [#7700](https://github.com/Automattic/sensei/pull/7700)
+
+### Fixed
+- Horizontal scroll on Course page when using Course theme [#7705](https://github.com/Automattic/sensei/pull/7705)
+- Loading some translations too early which generates a warning on WP 6.7 [#7701](https://github.com/Automattic/sensei/pull/7701)
+- PHP deprecation notice in View Results block [#7680](https://github.com/Automattic/sensei/pull/7680)
+- Hello elementor theme throwing 404 when rendering the Courses archive page [#7683](https://github.com/Automattic/sensei/pull/7683)
+- Label on course complete email received by the teacher [#7672](https://github.com/Automattic/sensei/pull/7672)
+- Timed quiz not stopping when time ends [#7675](https://github.com/Automattic/sensei/pull/7675)
+
+### Development
+- Added a hook to conditionally render the lesson actions in the frontend [#7677](https://github.com/Automattic/sensei/pull/7677)
+- Filter course IDs associated with a given teacher [#7702](https://github.com/Automattic/sensei/pull/7702)
+
 ## 4.24.3 - 2024-08-22
 ### Fixed
 - Ensure quiz description is displayed to the student [#7669](https://github.com/Automattic/sensei/pull/7669)

includes/admin/class-sensei-learner-management.php

@@ -98,7 +98,7 @@ public function __construct( $file ) {
 	/**
 	 * Graceful fallback for deprecated properties.
 	 *
-	 * @since $$next-version$$
+	 * @since 4.24.4
 	 *
 	 * @param string $key The key to get.
 	 *
@@ -722,7 +722,7 @@ private function can_user_manage_students( int $course_id, int $post_author ): b
 		/**
 		 * Filter the user IDs that have permission to manage students in a given course.
 		 *
-		 * @since $$next-version$$
+		 * @since 4.24.4
 		 *
 		 * @hook sensei_learners_allowed_user_ids
 		 *

includes/class-sensei-analysis.php

@@ -77,7 +77,7 @@ public function __get( $key ) {
 	/**
 	 * Get the screen name.
 	 *
-	 * @since $$next-version$$
+	 * @since 4.24.4
 	 *
 	 * @return string
 	 */

includes/class-sensei-grading.php

@@ -52,7 +52,7 @@ public function __construct( $file ) {
 	/**
 	 * Graceful fallback for deprecated properties.
 	 *
-	 * @since $$next-version$$
+	 * @since 4.24.4
 	 *
 	 * @param string $key The key to get.
 	 *

includes/class-sensei-lesson.php

@@ -5077,7 +5077,7 @@ public static function should_show_lesson_actions( int $lesson_id, int $user_id
 		/**
 		 * Filters if the lesson actions should be shown.
 		 *
-		 * @since $$next-version$$
+		 * @since 4.24.4
 		 *
 		 * @hook sensei_lesson_show_actions
 		 *

includes/class-sensei-posttypes.php

@@ -1,4 +1,7 @@
 <?php
+
+use Sensei\Internal\Emails\Email_Post_Type;
+
 if ( ! defined( 'ABSPATH' ) ) {
 	exit; // Exit if accessed directly
 }
@@ -111,6 +114,7 @@ public function __construct() {
 
 		// REST API functionality.
 		add_action( 'rest_api_init', [ $this, 'setup_rest_api' ] );
+		add_filter( 'rest_post_search_query', [ $this, 'exclude_post_types_from_rest_search' ] );
 
 		// Add protections on feeds for certain CPTs.
 		add_action( 'wp', [ $this, 'protect_feeds' ] );
@@ -128,7 +132,7 @@ public function __construct() {
 	/**
 	 * Graceful fallback for deprecated properties.
 	 *
-	 * @since $$next-version$$
+	 * @since 4.24.4
 	 *
 	 * @param string $key The key to get.
 	 *
@@ -177,6 +181,28 @@ public function setup_rest_api() {
 		add_filter( 'post_password_required', [ $this, 'lesson_is_protected' ], 10, 2 );
 	}
 
+	/**
+	 * Exclude post types from the REST API search.
+	 *
+	 * @since 4.24.4
+	 * @access private
+	 *
+	 * @param array $args The query args.
+	 * @return array The modified query args.
+	 */
+	public function exclude_post_types_from_rest_search( $args ) {
+		$excluded_post_types = [
+			'sensei_message',
+			Email_Post_Type::POST_TYPE,
+		];
+
+		if ( isset( $args['post_type'] ) ) {
+			$args['post_type'] = array_diff( (array) $args['post_type'], $excluded_post_types );
+		}
+
+		return $args;
+	}
+
 	/**
 	 * Add protection to Sensei post type feeds.
 	 *

includes/class-sensei-quiz.php

@@ -113,7 +113,7 @@ public function __construct( $file = __FILE__ ) {
 	 *
 	 * @internal
 	 *
-	 * @since  $$next-version$$
+	 * @since  4.24.4
 	 * @return void
 	 */
 	public function enqueue_styles() {

includes/class-sensei-settings-api.php

@@ -140,7 +140,7 @@ public function __construct() {
 	/**
 	 * Graceful fallback for deprecated properties.
 	 *
-	 * @since $$next-version$$
+	 * @since 4.24.4
 	 *
 	 * @param string $key The key to get.
 	 *

includes/class-sensei-teacher.php

@@ -841,7 +841,7 @@ public function filter_learners_query( $learners_sql ) {
 		/**
 		 * Filter the course IDs associated with a given teacher.
 		 *
-		 * @since $$next-version$$
+		 * @since 4.24.4
 		 *
 		 * @hook sensei_teacher_course_ids
 		 *