Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix students context menu #6143

Closed
wants to merge 3 commits into from
Closed

Fix students context menu #6143

wants to merge 3 commits into from

Conversation

mikeyarce
Copy link
Member

@mikeyarce mikeyarce commented Nov 19, 2022

Changes proposed in this Pull Request

  • Update @wp-components to version wp-6.1

With the old component, there is a problem with the students context menu not showing properly. Updating to the latest component fixes that issue.

Testing instructions

  • Go to Sensei -> Students
  • Click the ... menu
  • Make sure it opens up

Example:
student-context-menu

Also, I wasn't sure if I needed to push package-lock.json? It wasn't in .gitignore so.... let me know!

@mikeyarce mikeyarce requested a review from a team November 20, 2022 19:21
Copy link
Contributor

@onubrooks onubrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Some JS tests seem to be failing though so I would check and fix them first.

Updating the wp-components package required updates to the tests so that we're following the right methods.
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #6143 (e771b33) into trunk (e29a21b) will increase coverage by 0.00%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #6143   +/-   ##
=========================================
  Coverage     45.81%   45.81%           
- Complexity     9482     9483    +1     
=========================================
  Files           455      455           
  Lines         33543    33545    +2     
  Branches        271      271           
=========================================
+ Hits          15367    15368    +1     
- Misses        17974    17975    +1     
  Partials        202      202           
Impacted Files Coverage Δ
includes/class-sensei-utils.php 54.21% <0.00%> (ø)
...sensei-reports-overview-data-provider-students.php 80.76% <ø> (ø)
...in/home/tasks/class-sensei-home-tasks-provider.php 77.61% <30.00%> (ø)
.../class-sensei-rest-api-course-utils-controller.php 72.50% <36.36%> (ø)
...dmin/home/help/class-sensei-home-help-provider.php 96.42% <50.00%> (-3.58%) ⬇️
includes/blocks/class-sensei-block-take-course.php 73.77% <100.00%> (ø)
includes/class-sensei-lesson.php 37.11% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d999da...e771b33. Read the comment docs.

@gikaragia
Copy link
Contributor

Hey @mikeyarce, I think we need to resolve the conflicts on this one.

@mikeyarce
Copy link
Member Author

It was easier to just push a new branch so closing this one in favour of: #6440

@mikeyarce mikeyarce closed this Jan 29, 2023
@m1r0 m1r0 deleted the fix/students-context-menu branch February 2, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants